[Engine-devel] Shared disk / Floating disk import/export (was: Re: move disk command)

[Ayal Baron]

----- Original Message -----
> 
> 
> ----- Original Message -----
> > From: "Ayal Baron" <abaron at redhat.com>
> > To: "Omer Frenkel" <ofrenkel at redhat.com>
> > Cc: engine-devel at ovirt.org, "Jon Choate" <jchoate at redhat.com>,
> > "Maor" <mlipchuk at redhat.com>
> > Sent: Wednesday, January 18, 2012 10:20:01 AM
> > Subject: Re: Shared disk / Floating disk import/export (was: Re:
> > [Engine-devel] move disk command)
> > 
> > 
> > 
> > ----- Original Message -----
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Ayal Baron" <abaron at redhat.com>
> > > > To: "Maor" <mlipchuk at redhat.com>
> > > > Cc: engine-devel at ovirt.org, "Jon Choate" <jchoate at redhat.com>,
> > > > "Omer Frenkel" <ofrenkel at redhat.com>
> > > > Sent: Tuesday, January 17, 2012 10:21:29 PM
> > > > Subject: Re: Shared disk / Floating disk import/export (was:
> > > > Re:
> > > > [Engine-devel] move disk command)
> > > > 
> > > > 
> > > > 
> > > > ----- Original Message -----
> > > > > On 01/17/2012 11:57 AM, Omer Frenkel wrote:
> > > > > > 
> > > > > > 
> > > > > > ----- Original Message -----
> > > > > >> From: "Ayal Baron" <abaron at redhat.com>
> > > > > >> To: "Omer Frenkel" <ofrenkel at redhat.com>
> > > > > >> Cc: engine-devel at ovirt.org, "Jon Choate"
> > > > > >> <jchoate at redhat.com>
> > > > > >> Sent: Tuesday, January 17, 2012 10:45:53 AM
> > > > > >> Subject: Shared disk / Floating disk import/export (was:
> > > > > >> Re:
> > > > > >> [Engine-devel] move disk command)
> > > > > >>
> > > > > >>
> > > > > >> [SNIP]
> > > > > >>
> > > > > >>>>> This may be unrelated, but user would be allowed to
> > > > > >>>>> export
> > > > > >>>>> and
> > > > > >>>>> import a floating disk, right?
> > > > > >>>>> I would like the ability to import *any* disk in the
> > > > > >>>>> export
> > > > > >>>>> domain
> > > > > >>>>> as a floating disk, but in the least, export and import
> > > > > >>>>> disks
> > > > > >>>>> not
> > > > > >>>>> associated with a VM.
> > > > > >>>
> > > > > >>> you are right, it is unrelated, this thread is about move
> > > > > >>> disk
> > > > > >>> of
> > > > > >>> a
> > > > > >>> vm between SDs,
> > > > > >>> export and import is copy, and floating disks is part of
> > > > > >>> the
> > > > > >>> shared
> > > > > >>> disk feature,
> > > > > >>> this indeed need to be discussed in that scope.
> > > > > >>
> > > > > >> Ok, so I've changed the subject, now let's discuss it.
> > > > > >>
> > > > > > 
> > > > > > Adding Maor,
> > > > > > not sure if we have any plan regard export/import of
> > > > > > floating
> > > > > > disk,
> > > > > > or in general, exporting disk without it's vm (if I
> > > > > > understood
> > > > > > Ayal
> > > > > > correctly)
> > > > > > 
> > > > > > Maor, any comments?
> > > > > I remember, we mentioned export/import issue in our last
> > > > > meeting
> > > > > with
> > > > > Andrew in the context of shared raw disk.
> > > > > It was decided then, that export/import will not be supported
> > > > > by
> > > > > shared
> > > > > raw disk, I'm not sure if we also decided that for floating
> > > > > disk,
> > > > > but I think its a PM decision.
> > > > > 
> > > > > Support import/export domain might evolve to a big change,
> > > > > since
> > > > > if
> > > > > we
> > > > > want to export disk, we might also want to reflect all its
> > > > > configuration
> > > > > and functionality there, also reflect disks which are
> > > > > attached
> > > > > to
> > > > > VMs
> > > > > and templates as well.
> > > > 
> > > > What properties does a disk have?
> > > > Interface is what type of connection is used when plugging the
> > > > disk
> > > > in the computer (VM) so it's not really a disk property.
> > > > Address is also VM specific
> > > > Description is already stored in storage side.
> > > > What else do you have for disk?
> > > 
> > > type (system/data..)
> > 
> > Didn't we recently have a discussion about this being irrelevant?
> 
> as long it is visible to the user, no.

It's meaningless.

> 
> > 
> > > post-zero
> > 
> > Can assume always true
> 
> i disagree

It's the default behaviour for files, no reason to not allow users to import disk because of this.

> 
> > 
> > > name(?)
> > 
> > This exists on storage side
> 
> in addition to description?

there is uuid and description, do you store in addition another name?

> 
> > 
> > > creation-date
> > 
> > When imported
> 
> no!

Hmmm, I love how elaborate your explanations are.
It's common with files, no reason to treat differently.

> 
> > 
> > > last modify date
> > 
> > This exists on storage side
> > 
> > > application-list
> > 
> > Has nothing to do with disk, it's a VM property
> 
> no!

Again, very elaborate...
VM has 3 disks, guest reports app-list for the VM, how do you determine which disk has which apps?
If this is currently a disk property in engine then it's a bug.

> 
> > 
> > > volume type and format
> > 
> > This exists on storage side
> > 
> > > 
> > > > 
> > > > Note that being able to import floating disks means that we'd
> > > > be
> > > > able
> > > > to take any data storage domain and import any disk(s) from it
> > > > (assuming user changes domain type to export domain, which
> > > > users
> > > > already know how to do)
> > > > 
> > > > 
> > > 
> > 
>