[Engine-devel] java 1.6 compatibility no more?

[Yair Zaslavsky]

On 07/19/2012 11:09 AM, Vojtech Szocs wrote:
>> As I previously emailed - JDK7 already fixed a known issue with ldap and
>> DNS ,and made one of my patches at gerrit redundant.
>> Why not enjoy the bug fixes?
> 
> I agree, but in that case, why not switch to '1.7' Java source/target compliance for oVirt Maven build as well?
> 
> If JDK6 cannot be used for building oVirt (because of missing Java 7 APIs, because of LDAP/DNS issues in JDK6, etc.), we should also update our Maven POM files. Currently, when I import oVirt projects into Eclipse (using Eclipse Maven plugin), I'm getting compile errors on 'bll' project. This is because our Maven POM files declare '1.6' Java source/target compliance.
> 
+1 here - whatever it takes ;)

> Juan - you are right, but for me, it sounds quite strange to have '1.6' Java source/target compliance for Maven build, and use JDK7 to do the build.
> 
> Vojtech
> 
> 
> ----- Original Message -----
> From: "Yair Zaslavsky" <yzaslavs at redhat.com>
> To: engine-devel at ovirt.org
> Sent: Thursday, July 19, 2012 7:59:45 AM
> Subject: Re: [Engine-devel] java 1.6 compatibility no more?
> 
> On 07/18/2012 08:21 PM, Juan Hernandez wrote:
>> On 07/18/2012 06:33 PM, Vojtech Szocs wrote:
>>> In fact, for both backend and frontend, Maven effective POM contains:
>>>
>>> <artifactId>maven-compiler-plugin</artifactId>
>>> <configuration>
>>>   <source>1.6</source>
>>>   <target>1.6</target>
>>> </configuration>
>>>
>>> Therefore, according to Maven POM files, oVirt should be build-able using Java 6, but it's not. (?)
>>
>> These maven settings just tell the java compiler to accept Java 6 syntax
>> only and to generate a Java 6 compatible .class file format, but they
>> don't restrict the set of APIs that can be used.
>>
>>> The problem is in backend/manager/modules/bll: StorageDomainCommandBase class uses new Java 7 Long.compare() static method.
>>>
>>> I think we should decide if we want to be compliant with Java 7, or submit a patch that uses Java 6 API (Long.compareTo instance method).
>>>
>>> Vojtech
> 
> As I previously emailed - JDK7 already fixed a known issue with ldap and
> DNS ,and made one of my patches at gerrit redundant.
> Why not enjoy the bug fixes?
> 
>>>
>>>
>>> ----- Original Message -----
>>> From: "Laszlo Hornyak" <lhornyak at redhat.com>
>>> To: "engine-devel" <engine-devel at ovirt.org>
>>> Cc: "Vojtech Szocs" <vszocs at redhat.com>
>>> Sent: Wednesday, July 18, 2012 5:43:34 PM
>>> Subject: java 1.6 compatibility no more?
>>>
>>> Hi,
>>>
>>> It may be a historic moment, but for a few hours oVirt engine is no longer building on java 1.6.
>>> Is this intentional?
>>>
>>> Laszlo
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>
>>
>>
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel