[Engine-devel] eclipse juno vs gwt

[Maor Lipchuk]

Hi Laszlo,
Why not change the eclipse configuration, that it won't add @override
annotation when saving the class (Java - Editor -Save Actions)
but instead use warning instead (java - compiler - Errors/Warnings)

Regards,
Maor

On 11/05/2012 07:08 PM, Laszlo Hornyak wrote:
> http://youtu.be/XQ0JmfKs21g
> 
> 
> 
> ----- Original Message -----
>> From: "Christopher Morrissey" <Christopher.Morrissey at netapp.com>
>> To: "Laszlo Hornyak" <lhornyak at redhat.com>, "engine-devel" <engine-devel at ovirt.org>
>> Sent: Friday, November 2, 2012 11:43:23 PM
>> Subject: RE: [Engine-devel] eclipse juno vs gwt
>>
>> Sorry to follow up my own question, but can you give some specific
>> cases where this would be a problem? Thanks!
>>
>> -Chris
>>
>>
>> -----Original Message-----
>> From: Morrissey, Christopher
>> Sent: Friday, November 02, 2012 6:41 PM
>> To: 'Laszlo Hornyak'; engine-devel
>> Subject: RE: [Engine-devel] eclipse juno vs gwt
>>
>> Hi Laszlo,
>>
>> I have several methods that define the @Override annotation and
>> return something different from the super class. I haven't had any
>> problems compiling them in GWT. The return value does extend from
>> the return value of the super class, although this is a requirement
>> in Java as well so I'm not sure where the difference is.
>>
>> -Chris
>>
>>
>> -----Original Message-----
>> From: engine-devel-bounces at ovirt.org
>> [mailto:engine-devel-bounces at ovirt.org] On Behalf Of Laszlo Hornyak
>> Sent: Friday, November 02, 2012 6:19 AM
>> To: engine-devel
>> Subject: [Engine-devel] eclipse juno vs gwt
>>
>> Hi,
>>
>> Just noticed that eclipse juno is adding @Ovewrride annotations to
>> methods that are actually overriding something, like in many cases
>> clone and equals methods in some of the classes. This is fine for
>> the java compiler, but it in some cases the GWT compiler is not
>> going to accept this annotation. E.g. if the return type is
>> different than the method with same name in the superclass.
>>
>> Juno is doing this by default without asking, when saving the file.
>> So be extra-careful when editing java classes if they are shared
>> with GWT
>>
>> Laszlo
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>