[Engine-devel] VdcActionType.MoveOrCopyDisk

[Daniel Erez]

----- Original Message -----
> From: "Michael Pasternak" <mpastern at redhat.com>
> To: "Daniel Erez" <derez at redhat.com>
> Cc: "Einav Cohen" <ecohen at redhat.com>, "Ayal Baron" <abaron at redhat.com>, "Omer Frenkel" <ofrenkel at redhat.com>
> Sent: Thursday, October 11, 2012 1:27:48 PM
> Subject: Re: VdcActionType.MoveOrCopyDisk
> 
> On 10/11/2012 01:24 PM, Daniel Erez wrote:
> > From the log it seems that only one call to CopyImageVDSCommand
> > disk has been invoked.
> > Where do see it copying all template's disks?
> 
> later when i fetch all template's disks they all has new SD in
> storagedomains LIST.

I've tried it on my setup and checked the DB ('all_disks' view) - looks fine, only the selected disk has been copied.
How did you fetch the template's disks list (which query)?

> 
> > 
> > ----- Original Message -----
> >> From: "Michael Pasternak" <mpastern at redhat.com>
> >> To: "Ayal Baron" <abaron at redhat.com>, "Omer Frenkel"
> >> <ofrenkel at redhat.com>
> >> Cc: "Daniel Erez" <derez at redhat.com>, "Einav Cohen"
> >> <ecohen at redhat.com>
> >> Sent: Thursday, October 11, 2012 1:05:00 PM
> >> Subject: VdcActionType.MoveOrCopyDisk
> >>
> >> AFAIU (from derez) VdcActionType.MoveOrCopyDisk used to copy
> >> single
> >> disk
> >> to another storagedomain, but i see that it's actually copying all
> >> template's
> >> disks to this SD, not sure this expected behaviour ...
> >>
> >>
> >>
> >> 2012-10-11 12:47:32,144 INFO
> >>  [org.ovirt.engine.core.bll.MoveOrCopyDiskCommand]
> >> (http--0.0.0.0-8080-1) [4473e7ae] Lock Acquired to object
> >> EngineLock
> >> [exclusiveLocks= key:
> >> 01f14d07-b519-4d2f-b573-b0f8a200cb3f value: DISK
> >> , sharedLocks= key: 05ad22e4-a1c4-4caf-97ab-48127233ca24 value:
> >> TEMPLATE
> >> ]
> >> 2012-10-11 12:47:32,277 INFO
> >>  [org.ovirt.engine.core.bll.MoveOrCopyDiskCommand]
> >> (http--0.0.0.0-8080-1) [4473e7ae] Running command:
> >> MoveOrCopyDiskCommand internal: false.
> >> Entities affected :  ID: 01f14d07-b519-4d2f-b573-b0f8a200cb3f
> >> Type:
> >> Disk
> >> 2012-10-11 12:47:32,399 INFO
> >>  [org.ovirt.engine.core.bll.MoveOrCopyImageGroupCommand]
> >> (http--0.0.0.0-8080-1) [4473e7ae] Running command:
> >> MoveOrCopyImageGroupCommand
> >> internal: true. Entities affected :  ID:
> >> 47dd3e38-c252-4586-b180-afc8e8011df1 Type: Storage
> >> 2012-10-11 12:47:32,416 INFO
> >>  [org.ovirt.engine.core.vdsbroker.irsbroker.CopyImageVDSCommand]
> >> (http--0.0.0.0-8080-1) [4473e7ae] START, CopyImageVDSCommand(
> >> storagePoolId =
> >> bfe850fc-14d0-4a06-a765-520a2b9e59e4, ignoreFailoverLimit = false,
> >> compatabilityVersion = 3.0, storageDomainId =
> >> 48e1c5d2-9e46-4824-b45c-fd8d8fe6a85a, imageGroupId =
> >> 01f14d07-b519-4d2f-b573-b0f8a200cb3f, imageId =
> >> f964947b-c88a-4c7e-aae1-7d8276e6eb23, dstImageGroupId =
> >> 01f14d07-b519-4d2f-b573-b0f8a200cb3f, vmId =
> >> 00000000-0000-0000-0000-000000000000, dstImageId =
> >> f964947b-c88a-4c7e-aae1-7d8276e6eb23, imageDescription = ,
> >> dstStorageDomainId = 47dd3e38-c252-4586-b180-afc8e8011df1,
> >> copyVolumeType = SharedVol, volumeFormat = RAW, preallocate =
> >> Sparse,
> >> postZero = false, force = false), log id: 4e1f11e4
> >> 2012-10-11 12:47:32,428 INFO
> >>  [org.ovirt.engine.core.vdsbroker.irsbroker.CopyImageVDSCommand]
> >> (http--0.0.0.0-8080-1) [4473e7ae] --
> >> CopyImageVDSCommand::ExecuteIrsBrokerCommand: calling 'copyImage'
> >> with two new parameters: description and UUID
> >> 2012-10-11 12:47:32,430 INFO
> >>  [org.ovirt.engine.core.vdsbroker.irsbroker.CopyImageVDSCommand]
> >> (http--0.0.0.0-8080-1) [4473e7ae] -- copyImage parameters:
> >>                 sdUUID=48e1c5d2-9e46-4824-b45c-fd8d8fe6a85a
> >>                 spUUID=bfe850fc-14d0-4a06-a765-520a2b9e59e4
> >>                 vmGUID=00000000-0000-0000-0000-000000000000
> >>                 srcImageGUID=01f14d07-b519-4d2f-b573-b0f8a200cb3f
> >>                 srcVolUUID=f964947b-c88a-4c7e-aae1-7d8276e6eb23
> >>                 dstImageGUID=01f14d07-b519-4d2f-b573-b0f8a200cb3f
> >>                 dstVolUUID=f964947b-c88a-4c7e-aae1-7d8276e6eb23
> >>                 descr=
> >> 012-10-11 12:47:32,851 INFO
> >>  [org.ovirt.engine.core.vdsbroker.irsbroker.CopyImageVDSCommand]
> >> (http--0.0.0.0-8080-1) [4473e7ae] FINISH, CopyImageVDSCommand,
> >> return:
> >> 00000000-0000-0000-0000-000000000000, log id: 4e1f11e4
> >> 2012-10-11 12:47:32,880 INFO
> >>  [org.ovirt.engine.core.bll.EntityAsyncTask]
> >>  (http--0.0.0.0-8080-1)
> >> [4473e7ae] EntityAsyncTask::Adding EntityMultiAsyncTasks object
> >> for
> >> entity
> >> f964947b-c88a-4c7e-aae1-7d8276e6eb23
> >> 2012-10-11 12:47:32,883 INFO
> >>  [org.ovirt.engine.core.bll.EntityMultiAsyncTasks]
> >> (http--0.0.0.0-8080-1) [4473e7ae]
> >> EntityMultiAsyncTasks::AttachTask:
> >> Attaching task
> >> 788f35e3-adc8-4c5b-82ff-9886b00a0965 to entity
> >> f964947b-c88a-4c7e-aae1-7d8276e6eb23.
> >> 2012-10-11 12:47:32,888 INFO
> >>  [org.ovirt.engine.core.bll.tasks.AsyncTaskUtils]
> >> (http--0.0.0.0-8080-1) [4473e7ae] Adding task
> >> 788f35e3-adc8-4c5b-82ff-9886b00a0965 to DataBase
> >> 2012-10-11 12:47:32,938 INFO
> >>  [org.ovirt.engine.core.bll.AsyncTaskManager]
> >>  (http--0.0.0.0-8080-1)
> >> [4473e7ae] Adding task 788f35e3-adc8-4c5b-82ff-9886b00a0965
> >> (Parent
> >> Command MoveOrCopyDisk, Parameters Type
> >> org.ovirt.engine.core.common.asynctasks.AsyncTaskParameters),
> >> polling hasn't started yet..
> >> 2012-10-11 12:47:32,997 INFO
> >>  [org.ovirt.engine.core.bll.MoveOrCopyDiskCommand]
> >> (http--0.0.0.0-8080-1) [4473e7ae] Lock freed to object EngineLock
> >> [exclusiveLocks= key:
> >> 01f14d07-b519-4d2f-b573-b0f8a200cb3f value: DISK
> >> , sharedLocks= key: 05ad22e4-a1c4-4caf-97ab-48127233ca24 value:
> >> TEMPLATE
> >>
> >>
> >>
> >> --
> >>
> >> Michael Pasternak
> >> RedHat, ENG-Virtualization R&D
> >>
> 
> 
> --
> 
> Michael Pasternak
> RedHat, ENG-Virtualization R&D
>