[Engine-devel] ok to sort login domains on backend?

[Greg Sheremeta]

Hi,

I'm working on https://bugzilla.redhat.com/785555 -- "domain selection list in login screen should be sorted alphabetically"

I was going to put the sort logic in the web apps, but it makes sense to just put it in the backend, specifically in GetDomainListQuery. (There is already a sort there, but it needs to be tweaked to put "internal" always last.) This would affect non-webapp clients (REST API), so I want to make sure there are no objections. Unit tests pass and it seems to work fine (screen attached).

Any objections?

Thanks,
Greg


Greg Sheremeta
Red Hat, Inc.
Sr. Software Engineer, RHEV
Cell: 919-807-1086
gshereme at redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: login domain selectbox.png
Type: image/png
Size: 19191 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20130830/8d07b9aa/attachment-0001.png>