[Engine-devel] CodeQuality/Automated Checking

[Yaniv Bronheim]

----- Original Message -----
> From: "Sven Kieske" <S.Kieske at mittwald.de>
> To: "Alon Bar-Lev" <alonbl at redhat.com>, "Eli Mesika" <emesika at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Thursday, December 12, 2013 2:16:53 PM
> Subject: Re: [Engine-devel] CodeQuality/Automated Checking
> 
> Yeah of course it's always better you stay POSIX compliant, if it's
> needed :)
> The bash example was just the first one I thought of.
> 
> Glad to see this idea got picked up so fast!

glad to cause this thread :) as it was my glitch leaving a "fi" out there
I'll be glad to review such patch as http://gerrit.ovirt.org/22332 for Vdsm 
doesn't look complicate to integrate it to vdsm code and run it as part of the make

+1

> 
> Am 12.12.2013 12:15, schrieb Alon Bar-Lev:
> > first, using bash is not a good idea... better to use POSIX compliant
> > shell.
> 
> --
> Mit freundlichen Grüßen / Regards
> 
> Sven Kieske
> 
> Systemadministrator
> Mittwald CM Service GmbH & Co. KG
> Königsberger Straße 6
> 32339 Espelkamp
> T: +49-5772-293-100
> F: +49-5772-293-333
> https://www.mittwald.de
> Geschäftsführer: Robert Meyer
> St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
> Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>