[Engine-devel] unit tests failing

[Alon Bar-Lev]

----- Original Message -----
> From: "Ewoud Kohl van Wijngaarden" <ewoud+ovirt at kohlvanwijngaarden.nl>
> To: "Laszlo Hornyak" <lhornyak at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Tuesday, January 29, 2013 5:36:35 PM
> Subject: Re: [Engine-devel] unit tests failing
> 
> May I recommend git bisect? See http://lwn.net/Articles/317154/ or
> http://clock.co.uk/tech-blogs/git-bisect-simple-examples-and-automation
> as well.

This is way too time consuming from unrelated party that needs to progress with his own tasks.

> 
> First you find a known BAD, for example master. Then you find a known
> GOOD (for example 100 commits ago in master: master~100). Then we can
> use a script to determine if it's good. I'm assuming mvn test will be
> sufficient, but maybe you can refine this to only test for a specific
> unit test.
> 
> git bisect start BAD GOOD
> git bisect run mvn test
> 
> Now it will do a binary search in your history trying to find the
> commit
> that broke mvn test.
> 
> On Tue, Jan 29, 2013 at 10:13:20AM -0500, Laszlo Hornyak wrote:
> > Probably it is not yours, I removed
> > ff64900b7ae1b2d92e40bb290c61354d846d7d30 and still failing.
> > 
> > ----- Original Message -----
> > > From: "Federico Simoncelli" <fsimonce at redhat.com>
> > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > Cc: "engine-devel" <engine-devel at ovirt.org>
> > > Sent: Tuesday, January 29, 2013 4:05:10 PM
> > > Subject: Re: [Engine-devel] unit tests failing
> > > 
> > > I'll need to fix those tests, sorry.
> > > Working on it right now.
> > > 
> > > --
> > > Federico
> > > 
> > > ----- Original Message -----
> > > > From: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > To: "engine-devel" <engine-devel at ovirt.org>, "Federico
> > > > Simoncelli"
> > > > <fsimonce at redhat.com>, "Ofri Masad"
> > > > <omasad at redhat.com>
> > > > Sent: Tuesday, January 29, 2013 3:53:36 PM
> > > > Subject: unit tests failing
> > > > 
> > > > Don't know what change exactly caused this:
> > > > 
> > > > Tests in error:
> > > >   canDoActionInvalidVmStatus(org.ovirt.engine.core.bll.MoveDisksCommandTest)
> > > >   moveDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest)
> > > >   liveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest)
> > > >   liveMigrateDiskBasedOnTemplate(org.ovirt.engine.core.bll.MoveDisksCommandTest)
> > > >   moveDiskAndLiveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest)
> > > > 
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel at ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>