[Engine-devel] checkstyle and tools project

[Eyal Edri]

i believe it's running by default every time you run mvn compile (or install),
so actually findbugs job will catch checkstyle errors too. (i.e fail to compile)

----- Original Message -----
> From: "Itamar Heim" <iheim at redhat.com>
> To: "Eyal Edri" <eedri at redhat.com>
> Cc: "Laszlo Hornyak" <lhornyak at redhat.com>, "engine-devel" <engine-devel at ovirt.org>, "infra" <infra at ovirt.org>
> Sent: Monday, June 24, 2013 9:57:02 PM
> Subject: Re: [Engine-devel] checkstyle and tools project
> 
> On 06/24/2013 05:28 PM, Eyal Edri wrote:
> > Can we add a gerrit hook to run checkstyle on the code?
> 
> i wouldn't want gerrit to build, but can we add this to jenkins job?
> 
> > rather than waiting it to be merged and fail on jenkins?
> >
> > ----- Original Message -----
> >> From: "Laszlo Hornyak" <lhornyak at redhat.com>
> >> To: "engine-devel" <engine-devel at ovirt.org>
> >> Sent: Monday, June 24, 2013 11:15:38 AM
> >> Subject: [Engine-devel] checkstyle and tools project
> >>
> >> Hi,
> >>
> >> Checkstyle is not executed on tools project. I have sent a patch to gerrit
> >> to
> >> fix this, could you guys review?
> >>
> >> http://gerrit.ovirt.org/15719
> >>
> >> And there are some more cleanup patches for tools:
> >> http://gerrit.ovirt.org/15720
> >> http://gerrit.ovirt.org/15721
> >> http://gerrit.ovirt.org/15722
> >>
> >>
> >> Thank you,
> >> Laszlo
> >> _______________________________________________
> >> Engine-devel mailing list
> >> Engine-devel at ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> >
> 
>