[Engine-devel] findbugs [normal priority] - *please fix ASAP*

[Eyal Edri]

thanks guys for the help, 

we're planning to add a findbugs jos to run per patch so you'll be able to see it before merging.

Eyal.

----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Lior Vernia" <lvernia at redhat.com>, "Daniel Erez" <derez at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Wednesday, May 29, 2013 12:03:35 AM
> Subject: Re: [Engine-devel] findbugs [normal priority] - *please fix ASAP*
> 
> many thanks Yair/Lior/Derez for checking/fixing/reviewing/verifying/merging.
> findbugs is now back to green:
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4338/
> 
> ----
> Regards,
> Einav
> 
> ----- Original Message -----
> > From: "Yair Zaslavsky" <yzaslavs at redhat.com>
> > To: "Einav Cohen" <ecohen at redhat.com>
> > Cc: "engine-devel" <engine-devel at ovirt.org>
> > Sent: Monday, May 27, 2013 8:17:03 AM
> > Subject: Re: [Engine-devel] findbugs [normal priority] - *please fix ASAP*
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Einav Cohen" <ecohen at redhat.com>
> > > To: "engine-devel" <engine-devel at ovirt.org>
> > > Sent: Monday, May 27, 2013 3:07:55 PM
> > > Subject: [Engine-devel] findbugs [normal priority] - *please fix ASAP*
> > > 
> > > lvernia:
> > > find bugs error:
> > > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4323/findbugsResult/NORMAL/module.935532853/source.199038/#60
> > > in file:
> > > frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Uri.java
> > > caused by patch:
> > > http://gerrit.ovirt.org/#/c/14695/ [webadmin: Added validation to
> > > ProviderModel, merged: May 27]
> > > 
> > > ----
> > > 
> > > mkublin:
> > > find bugs error:
> > > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4323/findbugsResult/NORMAL/module.-609324659/source.198236/#342
> > > in file:
> > > backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
> > > caused by patch:
> > > http://gerrit.ovirt.org/#/c/13740/ [engine: Fixing perfomance issue
> > > between
> > > VdsRunTimeInfo and RunVmCommandBase, merged: Apr 10]
> > 
> > This should have been handled by the findbugs filter . The fact that it was
> > not handled means we still have an issue with filters.
> > I'm taking a look.
> > 
> > > 
> > > ----
> > > Thanks,
> > > Einav
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel at ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> > 
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>