[Engine-devel] Remove Comment column in main tabs

Tue Nov 26 16:44:49 UTC 2013

> ----- Original Message -----
> From: "Daniel Erez" <derez at redhat.com>
> Sent: Tuesday, November 26, 2013 11:24:30 AM
> 
> 
> 
> ----- Original Message -----
> > From: "Einav Cohen" <ecohen at redhat.com>
> > To: "Malini Rao" <mrao at redhat.com>, "Mike Kolesnik" <mkolesni at redhat.com>
> > Cc: "engine-devel" <engine-devel at ovirt.org>
> > Sent: Tuesday, November 26, 2013 6:17:18 PM
> > Subject: Re: [Engine-devel] Remove Comment column in main tabs
> > 
> > > ----- Original Message -----
> > > From: "Malini Rao" <mrao at redhat.com>
> > > Sent: Tuesday, November 26, 2013 11:06:17 AM
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Eli Mesika" <emesika at redhat.com>
> > > > To: "Mike Kolesnik" <mkolesni at redhat.com>
> > > > Cc: "engine-devel" <engine-devel at ovirt.org>
> > > > Sent: Tuesday, November 26, 2013 4:05:37 AM
> > > > Subject: Re: [Engine-devel] Remove Comment column in main tabs
> > > > 
> > > > 
> > > > 
> > > > ----- Original Message -----
> > > > > From: "Mike Kolesnik" <mkolesni at redhat.com>
> > > > > To: "engine-devel" <engine-devel at ovirt.org>
> > > > > Sent: Tuesday, November 26, 2013 8:44:34 AM
> > > > > Subject: [Engine-devel] Remove Comment column in main tabs
> > > > > 
> > > > > Hi,
> > > > > 
> > > > > When the comment RFE was added (in 3.3), there was also a column
> > > > > added
> > > > > to
> > > > > many main tabs.
> > > > > 
> > > > > I would like to propose to get rid of the column (which can only
> > > > > house
> > > > > one
> > > > > icon or no icon),
> > > > > and instead if there's a comment on an entity just display the icon
> > > > > with
> > > > > the
> > > > > tooltip adjacent to the name.
> > > > > 
> > > > > In this case the icon should probably be scaled down a bit since its
> > > > > huge.
> > > > > 
> > > > > I think this would be a good alternative and save us some valued
> > > > > screen
> > > > > real
> > > > > estate.
> > > > > 
> > > > > Thoughts, opinions?
> > > > 
> > > > +1
> > > 
> > > +1. But isn't there a limitation on appending an icon to a column that
> > > already has content? Also to fully consider pros and cons - if it is
> > > possible, we have to think of where to append this icon - prefix or
> > > suffix.
> > > If we prefix, then it is likely that some names will be preceded by 2
> > > icons
> > > because many of our lists have an icon already in the first column. If it
> > > is
> > > suffixed, the relative position on the icon will change based on how long
> > > the name is and if the object names tend to be long, then potentially,
> > > the
> > > icon is taking some room away.
> > 
> > see attached two options (both comparing the current state and a suggested
> > state in the VMs main tab) - not sure which one Mike had in mind.
> > option #1 is easy to implement while option #2, as Malini mentioned, may
> > be more difficult to implement.
> > also need to keep in mind that the today, the comment column real-estate is
> > taken mostly by the column title; therefore if we lose the title, we should
> > indicate in some other manner that this is the comment field of the object
> > (e.g. within the tooltip - also demonstrated in the attached).
> 
> +1
> I think that an image header might be a good solution.
> E.g. an image of a post-it note instead of the title.

good idea - we can display a "comment" tool-tip when hovering on the title-icon 
and, like today, display only the comment value within the tool-tip when hovering 
on the regular-row-icon (see attached). 
[we already have icon-column-titles in the application, e.g. "shareable", "bootable" 
in the Disks grid, so it shouldn't be hard to implement]

> 
> > 
> > > 
> > > Also worth considering is the fact that if we prefix the icon only on the
> > > rows where it is needed, it will be in a position that will definitely
> > > grab
> > > attention. So, it may be worthwhile to see if this is the icon that we
> > > should place here or if there is any other icon that deserves this
> > > attention
> > > in a consistent manner across entities.
> > > 
> > > While on the topic, it will also be a great idea IMHO to take a look at
> > > our
> > > various lists and see what columns are actually valuable for a default
> > > display. I think we are working on adding the ability to select columns
> > > for
> > > display and so the columns that we remove can be added back in by users
> > > when
> > > they want but do not sit there taking up room permanently. If anyone has
> > > ideas on what the default columns should be for one or many of the lists
> > > in
> > > our product, do send it to me. I will be willing to compile and
> > > consolidate
> > > the list and then post it back to the group for consideration.
> > > 
> > > 
> > > 
> > > > 
> > > > > 
> > > > > Regards,
> > > > > Mike
> > > > > 
> > > > > 
> > > > > _______________________________________________
> > > > > Engine-devel mailing list
> > > > > Engine-devel at ovirt.org
> > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > 
> > > > _______________________________________________
> > > > Engine-devel mailing list
> > > > Engine-devel at ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > 
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel at ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > 
> > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: move-comment-column--option-1-improved.png
Type: image/png
Size: 81567 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20131126/b5271203/attachment-0001.png>