[ovirt-devel] Please help us to review our restful API design with NUMA feature on ovirt

[Alexander Wels]

On Thursday, April 17, 2014 09:19:00 AM Liao, Chuan wrote:
> Hi Juan,
> 
> Before coding the restful API for NUMA feature, I want to make sure the
> following change list:
 
> Module restapi-definition
> rsdl_metadata.yaml - Add the NUMA definition.
> org.ovirt.engine.api.resource - Add NUMA related interface
> org.ovirt.engine.api.model - Add NUMA related model
> 
> Module restapi-jaxrs
> Org.ovirt.engine.api.restapi.resource - Add NUMA related interface implement
> class
 
> Module restapi-types
> Org.ovirt.engine.api.restapi.types - Add NUMA related BE entities mappers
> 
> It is appreciate that you could tell me if anything I lost for coding.
> Sorry for inconvenience.
> 
> Best Regards,
> Jason Liao
> 

Don't forget to add your resources to the LinkHelper class so it shows up when 
you call /ovirt-engine/api. Also make sure to add it to the FeaturesHelper 
class.

I also didn't see you mention the api.xsd. You will need to add the element 
definitions in there as well.

> 
> > -----Original Message-----
> > From: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > Sent: 2014年4月14日 13:58
> > To: 'Juan Hernandez'
> > Cc: devel at ovirt.org; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> > HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > Subject: RE: Please help us to review our restful API design with NUMA
> > feature on ovirt
 
> > Hi Juan
> > 
> > Thanks for your feedback. I have already update the wiki page with the
> > restful API
 calling BLL layer.
> > 
> > In this week, we are forcing on the 'shell patch' which include the BLL
> > query and action
 for NUMA (with dummy data), and submit this as a draft
> > in Gerrit. 
> > After shell patch is done, I will submit another patch 'restful patch'
> > which include the
 restful API for NUMA.
> > 
> > I am very appreciate that you will join the reviewer of these patches.
> > 
> > Best Regards,
> > Jason Liao
> > 
> > 
> > > -----Original Message-----
> > > From: Juan Hernandez [mailto:jhernand at redhat.com]
> > > Sent: 2014年4月10日 17:25
> > > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > > Cc: devel at ovirt.org; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> > > HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > Subject: Re: Please help us to review our restful API design with NUMA
> > > feature on ovirt
> > >
> > >
> > >
> > > On 04/10/2014 09:47 AM, Liao, Chuan (Jason Liao,
> > > HPservers-Core-OE-PSC)
> > > wrote:
> > > 
> > > > Hi Juan,
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > Please help us to review our restful API design with NUMA feature on
> > > > ovirt
> > > >
> > > >
> > > >
> > > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA#Interfa
> > > > ce
> > > > _and_data_structure_in_restful_API
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > We are appreciate that you or some community members could give us
> > > > some feedback and comments, and sorry for the nag.
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > *Best Regards,
> > > > *Jason Liao
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > > At the moment the RESTAPI design there is very light, so there is very
> > > little to comment. Only thing I can recommend at the moment is to use
> > > longer and clearer names for URL segments:
> > >
> > >
> > >
> > > /hosts/{host:id}/numanodes
> > > /vms/{vm:id}/numanodes
> > >
> > >
> > >
> > > Do you have any additional information about how you plan to implement
> > > the RESTAPI for NUMA?
> > >
> > >
> > >
> > > --
> > > Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
> > > 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid –
> > > C.I.F. B82657941
> 
> > - Red Hat S.L.
> 
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel