[ovirt-devel] [UI] Start/stop progress automatically

[Greg Sheremeta]

On 12/08/2014 09:01 AM, Lior Vernia wrote:
> Hello guys,
>
> I've made an attempt to solve the following bug, which deals with
> dialogs that don't display progress when dispatching backend actions and
> therefore enable users to create entities twice, etc.:
> https://bugzilla.redhat.com/show_bug.cgi?id=1167327
>
> I've posted a first patch [1] that is supposed to implement generic
> infrastructure to handle progress display based on async events. Put
> relevant reviewers as I saw fit.
>
> Posted another patch [2] that shows what kind of code will be made
> redundant by the previous patch - I have no intention of removing all
> that code myself, I trust maintainers to do so at their leisure.
>
> Of course future code won't require "manual" progress handling at all...
>
> The first patch also *seemingly* rendered a lot of code redundant in
> several storage/virt flows, which is removed [3]. Put relevant people as
> reviewers, but would also appreciate help verifying (as I'm not familiar
> with many of the flows, especially storage).
>
> Yours, Lior.
>
> [1] http://gerrit.ovirt.org/#/c/35964/
> [2] http://gerrit.ovirt.org/#/c/35965/
> [3] http://gerrit.ovirt.org/#/c/35966/
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>

Looks great to me. Frontend is very understandable, and much cleaner.
Well done. +1 to all :)

Greg

-- 
Greg Sheremeta
Red Hat, Inc.
Sr. Software Engineer, RHEV
Cell: 919-807-1086
gshereme at redhat.com