[ovirt-devel] Creating a new gerrit flag

[Yaniv Dary]

----- Original Message -----
> From: "Oved Ourfali" <ovedo at redhat.com>
> To: "David Caro" <dcaroest at redhat.com>
> Cc: infra at ovirt.org, devel at ovirt.org
> Sent: Tuesday, December 9, 2014 11:52:11 AM
> Subject: Re: [ovirt-devel] Creating a new gerrit flag
> 
> What happens when rebasing?
> We can't afford waiting for tests to run on each rebase... as we might end up
> rebasing forever.

why can't you rerun tests after rebase to run tests if the patch is critical and pending?

> 
> ----- Original Message -----
> > From: "David Caro" <dcaroest at redhat.com>
> > To: devel at ovirt.org, infra at ovirt.org
> > Sent: Tuesday, December 9, 2014 11:43:04 AM
> > Subject: [ovirt-devel] Creating a new gerrit flag
> > 
> > Hi!
> > 
> > e have been having an issue with gerrit patches being merged before
> > jenkins ran any tests on them, to avoid it from happening again I
> > propose creating a new gerrit flag (Tests) with the following
> > specifics:
> > 
> > 
> > +1 - Tests passed/overrided
> >  0 - Tests pending
> > -1 - Tests broken
> > 
> > where +1 is required to submit, +1 is set by jenkins when
> > passing the tests and -1 is set by jenkins in case it breaks any
> > tests. The +1 flag can be set also by maintainers to allow overriding
> > the process.
> > 
> > That way all the tests will be blocked until someone (hopefully
> > jenkins) adds the +1 flag, but if the maintainer wants to override the
> > value, she just has to set that flag herself.
> > 
> > 
> > What do you think?
> > 
> > 
> > --
> > David Caro
> > 
> > Red Hat S.L.
> > Continuous Integration Engineer - EMEA ENG Virtualization R&D
> > 
> > Tel.: +420 532 294 605
> > Email: dcaro at redhat.com
> > Web: www.redhat.com
> > RHT Global #: 82-62605
> > 
> > _______________________________________________
> > Devel mailing list
> > Devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>