[ovirt-devel] Creating a new gerrit flag

David Caro dcaroest at redhat.com
Tue Dec 9 13:40:30 UTC 2014


On 12/09, Oved Ourfali wrote:
> 
> 
> ----- Original Message -----
> > From: "Sven Kieske" <s.kieske at mittwald.de>
> > To: devel at ovirt.org
> > Sent: Tuesday, December 9, 2014 3:21:43 PM
> > Subject: Re: [ovirt-devel] Creating a new gerrit flag
> > 
> > 
> > 
> > On 09/12/14 13:47, Oved Ourfali wrote:
> > > safe up to 95% or so.
> > 
> > You just made up that number.
> > I don't really understand why you would want
> > to downgrade your code quality by circumventing tests.
> > 
> > Maybe someone can elaborate on this a bit?
> > 
> 
> It doesn't downgrade the code quality.
> It is just a way to ensure developers can both merge changes, and do it as safely as possible without relying on post-submit tools.
> The number is indeed invented... as I don't have real statistics, but it comes to say that it would be safe most of the time.
> After the patch is merged, if CI will fail, it is the responsibility of the developer to check that out and fix that.

This thread was started to avoid getting to that point, as getting a
failed patch inside the code means breaking all the other tests that
run on top of it and that blocks all the development, not only that
specific patch.

> 
> > --
> > Mit freundlichen Grüßen / Regards
> > 
> > Sven Kieske
> > 
> > Systemadministrator
> > Mittwald CM Service GmbH & Co. KG
> > Königsberger Straße 6
> > 32339 Espelkamp
> > T: +49-5772-293-100
> > F: +49-5772-293-333
> > https://www.mittwald.de
> > Geschäftsführer: Robert Meyer
> > St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
> > Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
> > _______________________________________________
> > Devel mailing list
> > Devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel

-- 
David Caro

Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D

Tel.: +420 532 294 605
Email: dcaro at redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20141209/667b494a/attachment-0001.sig>


More information about the Devel mailing list