[Engine-devel] Gerrit NEW Change Screen

[Itamar Heim]

On 01/26/2014 12:38 PM, Eli Mesika wrote:
>
>
> ----- Original Message -----
>> From: "Roy Golan" <rgolan at redhat.com>
>> To: "Itamar Heim" <iheim at redhat.com>, vdsm-devel at lists.fedorahosted.org, "engine-devel" <engine-devel at ovirt.org>
>> Sent: Sunday, January 26, 2014 9:12:38 AM
>> Subject: Re: [Engine-devel] Gerrit NEW Change Screen
>>
>> On 01/16/2014 12:08 AM, Itamar Heim wrote:
>>> with gerrit 2.8, there is a new change screen.
>>> its not enabled by default (yet), please use and see what you think.
>>>
>>> to enable, go to settings (click the top-right arrow next to your
>>> name, and choose settings).
>>> select preferences and set "Change View:" to "New Screen".
>
> I had found that the new window truncates the code
> See for example line 115 in http://gerrit.ovirt.org/#/c/23428/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java,cm
> Switching to the old view will show all the line while in the new one it is truncated

open a bug on gerrit upstream?

>
>>>
>>> Thanks,
>>>     Itamar
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> +1 needs some time to get used to the new layout but overall its way
>> better to have the patch dependency ("Related")
>> and better without the cluttered patch-sets view.
>> reminds me of gitk somewhat...
>>
>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>