[ovirt-devel] missing 'translations' in 'bundles/AuditLogMessages'

[Martin Mucha]

 Thanks for answers.

So I stick just to test default locale for given resource bundle.

But I've probably did not understand Omers answer ('currently commands that want to skip the audit logging are using this value'). If it means that AuditLogType.UNASSIGNED is used for switching off audit logging, then it definitely should be done differently, but for sake of this change it would be sufficient to exclude this enum value from testing, and in this case I would need remaining values (default locale translations) for given keys.

M.

----- Original Message -----
From: "Moti Asayag" <masayag at redhat.com>
To: "Einav Cohen" <ecohen at redhat.com>
Cc: "Martin Mucha" <mmucha at redhat.com>, devel at ovirt.org
Sent: Monday, July 7, 2014 2:43:10 PM
Subject: Re: [ovirt-devel] missing 'translations' in 'bundles/AuditLogMessages'



----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Martin Mucha" <mmucha at redhat.com>
> Cc: devel at ovirt.org
> Sent: Monday, July 7, 2014 3:38:08 PM
> Subject: Re: [ovirt-devel] missing 'translations' in 'bundles/AuditLogMessages'
> 
> - clarifying that by 'translations' you mean the (English) values
> for the AuditLogMessages keys that you detailed below.
> 
> [Pointing out that there are no translations, i.e. non-English
> translations, to AuditLogMessages at all - the main problem that
> prevents us from doing so is the fact that the message (English)
> value is the one that is persisted in the DB; we need to persist
> the key and the variables' values and construct the message per
> a 'localized' query request]
> 
> - I don't think that 'all existing' ResourceBundles should be
> tested, most of the time we will have missing translations in
> the code, since developers add/modify English text all the time,
> but are not taking care of their translations (which is fine) -
> translation is done in separate cycles.
> 

I think the intention is to verify any entry in the AuditLogType has a matching
record in [1] , and not that any placeholder has a proper translation value.

[1] ovirt-engine/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties

> ----
> Thanks,
> Einav
> 
> ----- Original Message -----
> > From: "Martin Mucha" <mmucha at redhat.com>
> > To: devel at ovirt.org
> > Sent: Monday, July 7, 2014 8:13:29 AM
> > Subject: [ovirt-devel] missing 'translations' in 'bundles/AuditLogMessages'
> > 
> > Hi,
> > 
> > I've did some changes in AuditLogDirector.java, triggered by wrong
> > behavior,
> > when some key (AuditLogType) is not present in ResourceBundle
> > 'bundles/AuditLogMessages', and wrote test to alert about missing
> > translations. To be able to merge these changes, I need to supply already
> > missing translations. For all following AuditLogType enums, silently
> > nothing
> > was saved to db when
> > org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector#log(org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogableBase)
> > was called.
> > 
> > Can somebody provide me missing translations for those keys?
> > 
> > Also test considers only default locale, should it test 'all existing'
> > ResourceBundles or is testing default one just sufficient? (technically
> > there's no difference at this time, since there's only default translation,
> > but if someone will provide new ResourceBundle currently it will be used
> > but
> > not tested)
> > 
> > ---
> > 
> > Key 'UNASSIGNED' is not translated in 'bundles/AuditLogMessages'
> > Key 'VDS_AUTO_FENCE_STATUS' is not translated in 'bundles/AuditLogMessages'
> > Key 'VDS_AUTO_FENCE_STATUS_FAILED' is not translated in
> > 'bundles/AuditLogMessages'
> > Key 'VDS_AUTO_FENCE_FAILED_CALL_FENCE_SPM' is not translated in
> > 'bundles/AuditLogMessages'
> > Key 'VDS_HIGH_NETWORK_USE' is not translated in 'bundles/AuditLogMessages'
> > Key 'USER_FAILED_REMOVE_VM' is not translated in 'bundles/AuditLogMessages'
> > Key 'USER_RUN_UNLOCK_ENTITY_SCRIPT' is not translated in
> > 'bundles/AuditLogMessages'
> > Key 'VDS_NETWORK_MTU_DIFFER_FROM_LOGICAL_NETWORK' is not translated in
> > 'bundles/AuditLogMessages'
> > Key 'VDS_HOST_IN_CONNECTING_STATE' is not translated in
> > 'bundles/AuditLogMessages'
> > Key 'STORAGE_ACTIVATE_ASYNC' is not translated in
> > 'bundles/AuditLogMessages'
> > Key 'DWH_STOPPED' is not translated in 'bundles/AuditLogMessages'
> > Key 'DWH_STARTED' is not translated in 'bundles/AuditLogMessages'
> > Key 'DWH_ERROR' is not translated in 'bundles/AuditLogMessages'
> > Key 'USER_REMOVE_AUDIT_LOG' is not translated in 'bundles/AuditLogMessages'
> > Key 'USER_REMOVE_AUDIT_LOG_FAILED' is not translated in
> > 'bundles/AuditLogMessages'
> > Key 'USER_CLEAR_ALL_DISMISSED_AUDIT_LOG' is not translated in
> > 'bundles/AuditLogMessages'
> > Key 'USER_CLEAR_ALL_DISMISSED_AUDIT_LOG_FAILED' is not translated in
> > 'bundles/AuditLogMessages'
> > 
> > thanks,
> > Martin.
> > _______________________________________________
> > Devel mailing list
> > Devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> > 
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>