[ovirt-devel] remote rejected - not Signed-off-by

[Nir Soffer]

----- Original Message -----
> From: "Kobi Ianko" <kobi at redhat.com>
> To: "Nir Soffer" <nsoffer at redhat.com>
> Cc: "engine-devel at ovirt.org" <devel at ovirt.org>
> Sent: Sunday, July 20, 2014 2:53:30 PM
> Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
> 
> 
> the git log:
> http://pastebin.com/RqbQAfa3

commit bacb57540fba62b0a5a715280a4a17421bdd8660
Author: Gilad Chaplik <gchaplik at redhat.com>
Date:   Wed May 28 20:40:22 2014 +0300

    db, core: aggregate qos and storage qos impl
    
    - DB and DAL changes: create qos table to accomodate qos objects and include
    storage qos and its limits.
    - added qos_sp.sql to add default sp.
    For more information see: http://www.ovirt.org/Features/aggregate_QoS,
    http://www.ovirt.org/Features/blkio-support
    Change-Id: I1a9af59277b5055453159f002f19046c0051d63b
    Signed-off-by: Gilad Chaplik <gchaplik at redhat.com>

This one does not have a footer - try to amend so you have a blank line
before the Change-Id: line.

> 
> my patches (3 patches) are based on Gilad Chaplik patches which are not
> merged
> 
> 
> ----- Original Message -----
> > From: "Nir Soffer" <nsoffer at redhat.com>
> > To: "Kobi Ianko" <kobi at redhat.com>
> > Cc: "engine-devel at ovirt.org" <devel at ovirt.org>
> > Sent: Sunday, July 20, 2014 2:48:06 PM
> > Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
> > 
> > ----- Original Message -----
> > > From: "Kobi Ianko" <kobi at redhat.com>
> > > To: "engine-devel at ovirt.org" <devel at ovirt.org>
> > > Sent: Sunday, July 20, 2014 1:17:36 PM
> > > Subject: [ovirt-devel] remote rejected - not Signed-off-by
> > > 
> > > Hi,
> > > Got this message when trying to push several changes:
> > > 
> > > To gerrit.ovirt.org:ovirt-engine
> > >  ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by
> > >  author/committer/uploader in commit message footer)
> > > error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
> > 
> > Can you share the output of git show up to the contents of the patch?
> > 
> > Nir
> > _______________________________________________
> > Devel mailing list
> > Devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> > 
>