[ovirt-devel] fixing whitespace in ui.xml files

[Greg Sheremeta]

I agree, 4 spaces for consistency.

Anyone else have an opinion?

----- Original Message -----
> From: "Vojtech Szocs" <vszocs at redhat.com>
> To: "Gilad Chaplik" <gchaplik at redhat.com>
> Cc: "Lior Vernia" <lvernia at redhat.com>, "Greg Sheremeta" <gshereme at redhat.com>, devel at ovirt.org, "Alexander Wels"
> <awels at redhat.com>, "Einav Cohen" <ecohen at redhat.com>, "Alona Kaplan" <alkaplan at redhat.com>, "Tomas Jelinek"
> <tjelinek at redhat.com>, "Juan Hernandez" <jhernand at redhat.com>
> Sent: Monday, June 2, 2014 6:13:10 AM
> Subject: Re: fixing whitespace in ui.xml files
> 
> 
> 
> ----- Original Message -----
> > From: "Gilad Chaplik" <gchaplik at redhat.com>
> > To: "Lior Vernia" <lvernia at redhat.com>
> > Cc: "Greg Sheremeta" <gshereme at redhat.com>, devel at ovirt.org, "Alexander
> > Wels" <awels at redhat.com>, "Vojtech Szocs"
> > <vszocs at redhat.com>, "Einav Cohen" <ecohen at redhat.com>, "Alona Kaplan"
> > <alkaplan at redhat.com>, "Tomas Jelinek"
> > <tjelinek at redhat.com>, "Juan Hernandez" <jhernand at redhat.com>
> > Sent: Thursday, May 29, 2014 2:28:59 PM
> > Subject: Re: fixing whitespace in ui.xml files
> > 
> > ----- Original Message -----
> > > From: "Lior Vernia" <lvernia at redhat.com>
> > > To: "Greg Sheremeta" <gshereme at redhat.com>
> > > Cc: devel at ovirt.org, "Alexander Wels" <awels at redhat.com>, "Vojtech Szocs"
> > > <vszocs at redhat.com>, "Einav Cohen"
> > > <ecohen at redhat.com>, "Alona Kaplan" <alkaplan at redhat.com>, "Gilad
> > > Chaplik"
> > > <gchaplik at redhat.com>, "Tomas Jelinek"
> > > <tjelinek at redhat.com>
> > > Sent: Thursday, May 29, 2014 2:56:29 PM
> > > Subject: Re: fixing whitespace in ui.xml files
> > > 
> > > Sounds good to me, I think the only reason they're not formatted is that
> > > the Java formatter by default ignores them.
> > > 
> > > On 29/05/14 14:51, Greg Sheremeta wrote:
> > > > Hi,
> > > > 
> > > > Can we agree to use the same .java file space standards in our gwt
> > > > ui.xml
> > > > files? Specifically: spaces only, no tabs, 4 spaces indent, no trailing
> > > > whitespace.
> > 
> > [adding Juan]
> > I agree on same formatting as api.xsd.
> 
> Hm, api.xsd seems to use 2 spaces per "tab", without a space before "/>"
> part.
> While none of these are that big of a deal, we should stay consistent with
> accompanying (Java) code, i.e. have single whitespace policy for both source
> and XML files. (The space before "/>" part is a courtesy to older XML/XHTML
> parsers and is not really important IMHO.)
> 
> > 
> > > > 
> > > > I have my Eclipse set to fix these things (with the anyedit plugin),
> > > > and
> > > > the ui.xml files always have tabs and trailing space in them.
> > > > 
> > > > If we agree, I volunteer to fix them all and post a patch. I think we
> > > > can
> > > > also set gerrit to point these out.
> > > > 
> > > > Thanks,
> > > > Greg
> > > > 
> > > > Greg Sheremeta
> > > > Red Hat, Inc.
> > > > Sr. Software Engineer, RHEV
> > > > Cell: 919-807-1086
> > > > gshereme at redhat.com
> > > > 
> > > 
> > 
>