[Engine-devel] Schema upgrade failure on master

[Martin Perina]

----- Original Message -----
> From: "Liran Zelkha" <liran.zelkha at gmail.com>
> To: "Martin Perina" <mperina at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Tuesday, March 4, 2014 10:15:47 AM
> Subject: Re: [Engine-devel] Schema upgrade failure on master
> 
> Happens to me too, on engine_dao_tests.
> DB is not empty, one line:
> engine_dao_tests=> select * from event_subscriber;
>             subscriber_id             | event_up_name | method_id |
> method_address | tag_name | notification_method
> --------------------------------------+---------------+-----------+----------------+----------+---------------------
>  9bf7c640-b620-456f-a550-0348f366544a | TestRun       |         1 |
>        | testrun  |
> (1 row)

This row caused the issue, I wonder how it was created when notification_method column is created
during 03_05_0050_event_notification_methods.sql script execution ...

Delete this row and after this run schema upgrade. I tested with master and empty db and dao tests work fine.

> 
> 
> 
> 
> On Tue, Mar 4, 2014 at 7:10 AM, Martin Perina <mperina at redhat.com> wrote:
> 
> > Hi Adam,
> >
> > I didn't notice any problem with this script. Was the database you tried
> > to upgrade empty?
> > If not could you please send me contents of your event_subscriber table?
> >
> > Thanks
> >
> > Martin Perina
> >
> > ----- Original Message -----
> > > From: "Adam Litke" <alitke at redhat.com>
> > > To: engine-devel at ovirt.org
> > > Sent: Monday, March 3, 2014 11:26:28 PM
> > > Subject: [Engine-devel] Schema upgrade failure on master
> > >
> > > Hi,
> > >
> > > I've recently rebased to master and it looks like the
> > > 03_05_0050_event_notification_methods.sql script is failing on schema
> > > upgrade.  Is this a bug or am I doing something wrong?  To upgrade I
> > > did the normal proceedure with my development installation:
> > >
> > > make install-dev ...
> > > ~/ovirt/bin/engine-setup
> > >
> > > Got this result in the log file:
> > >
> > >
> > psql:/home/alitke/ovirt-**FILTERED**/share/ovirt-**FILTERED**/dbscripts/upgrade/03_05_0050_event_notification_methods.sql:10:
> > > ERROR:  column "notification_method" contains null values
> > > FATAL: Cannot execute sql command:
> > >
> > --file=/home/alitke/ovirt-**FILTERED**/share/ovirt-**FILTERED**/dbscripts/upgrade/03_05_0050_event_notification_methods.sql
> > >
> > > 2014-03-03 17:20:34 DEBUG otopi.context context._executeMethod:152 method
> > > exception
> > > Traceback (most recent call last):
> > >   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 142, in
> > >   _executeMethod
> > >     method['method']()
> > >   File
> > >
> > "/home/alitke/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py",
> > >   line 280, in _misc
> > >     osetupcons.DBEnv.PGPASS_FILE
> > >   File "/usr/lib/python2.7/site-packages/otopi/plugin.py", line 451, in
> > >   execute
> > >     command=args[0],
> > > RuntimeError: Command
> > >
> > '/home/alitke/ovirt-**FILTERED**/share/ovirt-**FILTERED**/dbscripts/schema.sh'
> > > failed to execute
> > >
> > > --
> > > Adam Litke
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel at ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > >
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> >
>