[Engine-devel] REST API - where did bookmarks go?

Mon Mar 24 16:12:55 UTC 2014

----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Gilad Chaplik" <gchaplik at redhat.com>
> Cc: "Vojtech Szocs" <vszocs at redhat.com>, "Juan Hernandez" <jhernand at redhat.com>, "engine-devel"
> <engine-devel at ovirt.org>
> Sent: Monday, March 24, 2014 4:38:33 PM
> Subject: Re: [Engine-devel] REST API - where did bookmarks go?
> 
> Hi Gilad, "client-side Bookmarks" is a great suggestion

+1

My understanding is that bookmarks are just named search queries, whose main advantage is the ability to put (potentially complex) search query behind a friendly-named bookmark.

Bookmarks exist in WebAdmin GUI (as it provides the search panel) and as far as I can tell, there are no permissions involved when dealing with bookmarks via BookmarkDAO.

So it seems that bookmark data could be persisted locally (in browser) via HTML local storage. However, the disadvantage (as mentioned by Einav below) is per-browser persistence, instead of today's per-Engine persistence. If we are OK with per-browser persistence of bookmarks, I'm for it.

> however it is a (non-related) RFE, which may be implemented instead of, or in
> addition to, the already-existing server-side Bookmarks.
> 
> [keep in mind that server-side bookmarks allow you to add bookmarks
> that may be used by other users; it is also a feature that exists
> for a long time in oVirt, so need to think a little bit before
> removing it]
> 
> As long as we have server-side Bookmarks (i.e. as long as Bookmark
> is an engine-managed business entity), they need to be exposed via
> the REST API.

Indeed, this was the reason behind RFE https://bugzilla.redhat.com/1075556 - even after migrating to REST API, bookmark functionality should be preserved. (But we can also decide if we want to change that, if necessary.)

> 
> ----
> Thanks,
> Einav
> 
> ----- Original Message -----
> > From: "Gilad Chaplik" <gchaplik at redhat.com>
> > To: "Vojtech Szocs" <vszocs at redhat.com>
> > Cc: "Juan Hernandez" <jhernand at redhat.com>, "engine-devel"
> > <engine-devel at ovirt.org>
> > Sent: Monday, March 24, 2014 11:28:02 AM
> > Subject: Re: [Engine-devel] REST API - where did bookmarks go?
> > 
> > Hi Guys,
> > 
> > Why we need bookmarks in API? a single liner that points out to another
> > single liner?
> > I know that we need it for 'UI over REST' migration, but...
> > IMHO bookmarks should be saved in client side, maybe inject the search
> > string
> > in the url, and get 'real' bookmarks/favorites... I don't know :-)

Actually, the ability to put search string in WebAdmin URL is a *VERY* interesting idea!

For example:
- assume you login and land on WebAdmin.html#vms
- you change URL to WebAdmin.html#search;q=Host%3A%20name%20%3D%20asdasd [*]
- WebAdmin applies requested search string, performs place change to WebAdmin.html#hosts

[*] encodeURIComponent('Host: name = asdasd')

Not only would users be able to navigate WebAdmin through search string in URL, but UI plugins could do this too via some plugin API function.

Gilad, could you please create RFE for this? (it's a very good idea, IMHO)

> > 
> > Thanks,
> > Gilad.
> > 
> > ----- Original Message -----
> > > From: "Vojtech Szocs" <vszocs at redhat.com>
> > > To: "Juan Hernandez" <jhernand at redhat.com>
> > > Cc: "engine-devel" <engine-devel at ovirt.org>
> > > Sent: Wednesday, March 12, 2014 1:27:19 PM
> > > Subject: Re: [Engine-devel] REST API - where did bookmarks go?
> > > 
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Juan Hernandez" <jhernand at redhat.com>
> > > > To: "Vojtech Szocs" <vszocs at redhat.com>, "engine-devel"
> > > > <engine-devel at ovirt.org>
> > > > Cc: "Einav Cohen" <ecohen at redhat.com>
> > > > Sent: Tuesday, March 11, 2014 7:22:35 PM
> > > > Subject: Re: REST API - where did bookmarks go?
> > > > 
> > > > On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
> > > > > Hi guys,
> > > > > 
> > > > > as part of prototyping new JavaScript binding for oVirt REST API,
> > > > > we chose a couple of business entities (resources) to experiment
> > > > > with.
> > > > > 
> > > > > I just realized that requesting /ovirt-engine/api doesn't return
> > > > > any information about bookmarks. Where did bookmarks go? Is it
> > > > > possible to manage bookmarks through REST API?
> > > > > 
> > > > > Note: WebAdmin currently gets bookmarks through GWT RPC by calling
> > > > > GetAllBookmarksQuery. Bookmark seems like proper backend business
> > > > > entity (with DAO and everything) so it should be exposed also via
> > > > > REST API.. or am I missing something?
> > > > > 
> > > > > Thanks,
> > > > > Vojtech
> > > > > 
> > > > 
> > > > The didn't go anywhere, just never existed in the API. Please open a
> > > > RFE
> > > > to add them.
> > > 
> > > Thanks, Juan. The RFE is here:
> > > 
> > >   https://bugzilla.redhat.com/1075556
> > > 
> > > > 
> > > > --
> > > > Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
> > > > 3ºD, 28016 Madrid, Spain
> > > > Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat
> > > > S.L.
> > > > 
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel at ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > >
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> >
> 