[Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt
Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
xiao-lei.shi at hp.com
Mon Mar 31 12:20:33 UTC 2014
Thanks Eli.
I will move the vm level NUMA fields to vm_dynamic, and the related database schema will be updated accordingly.
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi at hp.com
-----Original Message-----
From: Eli Mesika [mailto:emesika at redhat.com]
Sent: Monday, March 31, 2014 5:49 PM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary; engine-devel at ovirt.org
Subject: Re: Please help us to review our database schema design with NUMA feature on ovirt
----- Original Message -----
> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi at hp.com>
> To: "Gilad Chaplik" <gchaplik at redhat.com>, "Eli Mesika"
> <emesika at redhat.com>, "Roy Golan" <rgolan at redhat.com>
> Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> <chuan.liao at hp.com>, "Doron Fediuck" <dfediuck at redhat.com>, "Chegu Vinod" <chegu_vinod at hp.com>, "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> <shangchun.liang at hp.com>, "Yaniv Dary" <ydary at redhat.com>,
> engine-devel at ovirt.org
> Sent: Monday, March 31, 2014 12:38:04 PM
> Subject: RE: Please help us to review our database schema design with
> NUMA feature on ovirt
>
> We put host level NUMA fields in vds_dynamic because these information
> are from host itself, and NUMA topology may be changed if the host's
> hardware make a change. NUMA information are similar to the host's cpu
> topology information like cpu_cores and cpu_sockets which are in
> vds_dynamic, we refer to this.
> VM level NUMA fields are configured by user, and actually we
> originally think they should be in vm_dynamic. But we found that the
> field of another feature cpuPin which is similar as NUMA feature is in
> vm_static, so we put vm NUMA fields in vm_static.
> Do you think we need to put VM level NUMA fields in vm_dynamic?
I think that in this case we should fix cpuPin to be in vm_dynamic and put after that the other NUMA fields in vm_dynamic as well
>
> Thanks & Best Regards
> Shi, Xiao-Lei (Bruce)
>
> Hewlett-Packard Co., Ltd.
> HP Servers Core Platform Software China Telephone +86 23 65683093
> Mobile +86 18696583447 Email xiao-lei.shi at hp.com
>
>
> -----Original Message-----
> From: Gilad Chaplik [mailto:gchaplik at redhat.com]
> Sent: Monday, March 31, 2014 5:22 PM
> To: Eli Mesika; Roy Golan
> Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Liao, Chuan (Jason Liao,
> HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun
> (David Liang, HPservers-Core-OE-PSC); Yaniv Dary; engine-devel at ovirt.org
> Subject: Re: Please help us to review our database schema design with NUMA
> feature on ovirt
>
> +1
>
> IMO: vds data should reside in static
> VM need to think about it.
>
> Roy?
>
> Thanks,
> Gilad.
>
>
> ----- Original Message -----
> > From: "Eli Mesika" <emesika at redhat.com>
> > To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi at hp.com>
> > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao at hp.com>,
> > "Doron Fediuck" <dfediuck at redhat.com>,
> > "Gilad Chaplik" <gchaplik at redhat.com>, "Chegu Vinod" <chegu_vinod at hp.com>,
> > "Shang-Chun Liang (David Liang,
> > HPservers-Core-OE-PSC)" <shangchun.liang at hp.com>, "Yaniv Dary"
> > <ydary at redhat.com>, engine-devel at ovirt.org
> > Sent: Monday, March 31, 2014 12:12:50 PM
> > Subject: Re: Please help us to review our database schema design with NUMA
> > feature on ovirt
> >
> >
> >
> > ----- Original Message -----
> > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi at hp.com>
> > > To: "Eli Mesika" <emesika at redhat.com>
> > > Cc: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao at hp.com>,
> > > "Doron Fediuck" <dfediuck at redhat.com>,
> > > "Gilad Chaplik" <gchaplik at redhat.com>, "Chegu Vinod"
> > > <chegu_vinod at hp.com>,
> > > "Shang-Chun Liang (David Liang,
> > > HPservers-Core-OE-PSC)" <shangchun.liang at hp.com>, "Yaniv Dary"
> > > <ydary at redhat.com>, engine-devel at ovirt.org
> > > Sent: Monday, March 31, 2014 8:56:20 AM
> > > Subject: RE: Please help us to review our database schema design with
> > > NUMA
> > > feature on ovirt
> > >
> > > Include the devel group.
> > > Thanks Eli for the quick responses for our first design and sorry for the
> > > nag.
> > > We appreciate any of the comments for our database design and will follow
> > > the
> > > design to do the implementation if no more comments.
> > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> >
> > Seems OK for me except an unanswered question I had asked in my first
> > review
> > :
> >
> > Why in the Host level NUMA fields are added to vds_dynamic while in the VM
> > level it is added to vm_static ???
> > I would expect it to be in both on static or dynamic , can you please
> > explain
> > ? Thanks
> >
> > >
> > > Thanks & Best Regards
> > > Shi, Xiao-Lei (Bruce)
> > >
> > > Hewlett-Packard Co., Ltd.
> > > HP Servers Core Platform Software China
> > > Telephone +86 23 65683093
> > > Mobile +86 18696583447
> > > Email xiao-lei.shi at hp.com
> > >
> > > -----Original Message-----
> > > From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > Sent: Friday, March 28, 2014 1:30 PM
> > > To: 'Eli Mesika'
> > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
> > > Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> > > HPservers-Core-OE-PSC); Yaniv Dary
> > > Subject: RE: Please help us to review our database schema design with
> > > NUMA
> > > feature on ovirt
> > >
> > > Hi Eli,
> > >
> > > After the UX design meeting, we did some modification for the database
> > > schema, and merged some update according to your last review comments.
> > > Now the document has been posted on ovirt wikipage, could you help to
> > > review
> > > the database design again:
> > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA
> > >
> > >
> > > Thanks & Best Regards
> > > Shi, Xiao-Lei (Bruce)
> > >
> > > Hewlett-Packard Co., Ltd.
> > > HP Servers Core Platform Software China Telephone +86 23 65683093 Mobile
> > > +86
> > > 18696583447 Email xiao-lei.shi at hp.com
> > >
> > >
> > > -----Original Message-----
> > > From: Eli Mesika [mailto:emesika at redhat.com]
> > > Sent: Monday, March 24, 2014 6:24 PM
> > > To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > > Cc: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck; Gilad
> > > Chaplik; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> > > HPservers-Core-OE-PSC); Yaniv Dary
> > > Subject: Re: Please help us to review our database schema design with
> > > NUMA
> > > feature on ovirt
> > >
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi at hp.com>
> > > > To: "Eli Mesika" <emesika at redhat.com>, "Chuan Liao (Jason Liao,
> > > > HPservers-Core-OE-PSC)" <chuan.liao at hp.com>
> > > > Cc: "Doron Fediuck" <dfediuck at redhat.com>, "Gilad Chaplik"
> > > > <gchaplik at redhat.com>, "Chegu Vinod" <chegu_vinod at hp.com>, "Shang-Chun
> > > > Liang (David Liang, HPservers-Core-OE-PSC)" <shangchun.liang at hp.com>
> > > > Sent: Monday, March 24, 2014 11:23:39 AM
> > > > Subject: RE: Please help us to review our database schema design with
> > > > NUMA feature on ovirt
> > > >
> > > > Hi Eli,
> > > >
> > > > Thanks for your comments.
> > > > I have updated the document according to your comments except the below
> > > > one:
> > > > Missing from here are 2 issues:
> > > >
> > > > 1) Impact on the search engine, which new columns are search-able and
> > > > which changes are planned in the search engine code to enable that
> > > >
> > > > 2) Impact on engine-reports, are those changed planned to be exposed
> > > > to the engine data warehouse and required new/modified reports?
> > > >
> > > > Could you tell us more detailed information about the modules you
> > > > mentioned above? I mean "search engine" and "engine-reports". I think
> > > > we missed these two parts in our previous investigation.
> > > > I just find org.ovirt.engine.core.bll.SearchQuery, is that the right
> > > > object for search engine?
> > >
> > > Yes, actually when you are opening the admin UI, there are TABs for each
> > > entity , i.e. Data Center, Cluster, Host etc.
> > > In each, you can see a text-box in which you can search for by writing a
> > > search expression My question is
> > > 1) What is the impact of your work on the search on the Fost and VM
> > > TABs
> > > a) Are there any fields that are supported now in the search
> > > expression
> > > and should pop-up when you write the expression by the
> > > auto-completion
> > > mechanism ?
> > > b) Are there any added columns displayed in the result of such a
> > > search
> > > in the grid ?
> > >
> > > > How about the engine-reports, could you give us some hints, like the
> > > > code location and any more detailed information that we can start more
> > > > investigation?
> > >
> > > CCing Yaniv D who is in charge of the reports/dwh module Yaniv, any
> > > planned
> > > work for adding Numa features to Host/VM in the reports side ?
> > >
> > > Thanks
> > >
> > > >
> > > > Thanks & Best Regards
> > > > Shi, Xiao-Lei (Bruce)
> > > >
> > > > Hewlett-Packard Co., Ltd.
> > > > HP Servers Core Platform Software China Telephone +86 23 65683093
> > > > Mobile +86 18696583447 Email xiao-lei.shi at hp.com
> > > >
> > > > -----Original Message-----
> > > > From: Eli Mesika [mailto:emesika at redhat.com]
> > > > Sent: Sunday, March 23, 2014 4:44 PM
> > > > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > > > Cc: Doron Fediuck; Gilad Chaplik; Vinod, Chegu; Liang, Shang-Chun
> > > > (David Liang, HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP
> > > > Servers-PSC-CQ)
> > > > Subject: Re: Please help us to review our database schema design with
> > > > NUMA feature on ovirt
> > > >
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)"
> > > > > <chuan.liao at hp.com>
> > > > > To: emesika at redhat.com
> > > > > Cc: "Doron Fediuck" <dfediuck at redhat.com>, "Gilad Chaplik"
> > > > > <gchaplik at redhat.com>, "Chegu Vinod" <chegu_vinod at hp.com>,
> > > > > "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> > > > > <shangchun.liang at hp.com>, "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
> > > > > <xiao-lei.shi at hp.com>
> > > > > Sent: Friday, March 21, 2014 10:42:33 AM
> > > > > Subject: Please help us to review our database schema design with
> > > > > NUMA feature on ovirt
> > > > >
> > > > > Hi Eli,
> > > > >
> > > > > Please help us to review our database schema design with NUMA
> > > > > feature on ovirt
> > > > > https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_IST
> > > > > Y8
> > > > > ykDr0I6VY/edit?usp=sharing
> > > > >
> > > > > Feel free to take comments on document at anywhere
> > > >
> > > > Done, had commented on the document.
> > > > Eli
> > > >
> > > > >
> > > > > Especially, 5.4 The used interface between engine core and
> > > > > database(schema)
> > > > >
> > > > > Your approve and your comments with this section will be much more
> > > > > appreciate for us.
> > > > >
> > > > > Best Regards,
> > > > > Jason Liao
> > > > >
> > > > >
> > > >
> > >
> >
>
More information about the Devel
mailing list