[ovirt-devel] Error pushing to gerrit

[David Caro]

On Tue 27 May 2014 05:39:28 PM CEST, Kobi Ianko wrote:
>
>
> ----- Original Message -----
>> From: "David Caro" <dcaroest at redhat.com>
>> To: "Kobi Ianko" <kobi at redhat.com>
>> Cc: devel at ovirt.org
>> Sent: Tuesday, May 27, 2014 6:25:22 PM
>> Subject: Re: [ovirt-devel] Error pushing to gerrit
>>
>> On Tue 27 May 2014 05:22:34 PM CEST, Kobi Ianko wrote:
>>> Hi All,
>>> when I try to push a patch I get:
>>>
>>>  ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by
>>>  author/committer/uploader in commit message footer)
>>> error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
>>>
>>>
>>> Although my patch is signed.
>>>
>>> Does someone have any clue how to solve this?
>>>
>>> 10x, Kobi
>>>
>>> _______________________________________________
>>> Devel mailing list
>>> Devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>> What does git log -1 show?
>
> git log looks good:
>
> commit b5f56e86c64af232d3794a6f1534100a28615e77
> Author: Kobi Ianko <kobi at redhat.com>
> Date:   Tue May 13 19:00:08 2014 +0300
>
>     core: New internal command, VmSlaPolicyCommand
>
>     Adding a new command to handle the SLA parameters.
>     For now the new command only contains the CPU Limit parameter
>     which limits the VM's CPU consumption.
>
>     This Command will be called from the updateVmCommand, and updateMomPolicyCommand.
>     later on it will be called from other parts of the system that configures SLA parameters.
>
>     Change-Id: I26b0794c52cfe1d352f26392a835023afcd9efa0
>     Bug-Url: https://bugzilla.redhat.com/1084930
>     Signed-off-by: Kobi Ianko <kobi at redhat.com>
>
>>
>> Probably the Signed-off-by header or it's not well places, or it's not
>> signed by the committer/author/uploader. So you can try to amend the
>> author, or the committer, or the header.
>>
>> --
>> David Caro
>>
>> Red Hat S.L.
>> Continuous Integration Engineer - EMEA ENG Virtualization R&D
>>
>> Email: dcaro at redhat.com
>> Web: www.redhat.com
>> RHT Global #: 82-62605
>>
>>
>> _______________________________________________
>> Devel mailing list
>> Devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel

Are you sure the are no extra spaces around the headers or extra 
newlines?

--
David Caro

Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D

Email: dcaro at redhat.com
Web: www.redhat.com
RHT Global #: 82-62605

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20140527/195164f7/attachment-0001.sig>