[ovirt-devel] [VDSM][JSON] jsonrpc coding/encoding performance on RHEL/Centos 6

Nir Soffer nsoffer at redhat.com
Tue Nov 11 10:31:37 UTC 2014


----- Original Message -----
> From: "Francesco Romani" <fromani at redhat.com>
> To: devel at ovirt.org
> Cc: "Nir Soffer" <nsoffer at redhat.com>
> Sent: Tuesday, November 11, 2014 12:24:43 PM
> Subject: Re: [ovirt-devel] [VDSM][JSON] jsonrpc coding/encoding performance on	RHEL/Centos 6
> 
> 
> 
> ----- Original Message -----
> > From: "Nir Soffer" <nsoffer at redhat.com>
> > To: "Francesco Romani" <fromani at redhat.com>
> > Cc: devel at ovirt.org
> > Sent: Monday, November 10, 2014 1:21:53 PM
> > Subject: Re: [ovirt-devel] [VDSM][JSON] jsonrpc coding/encoding performance
> > on	RHEL/Centos 6
> > 
> > We have vdsm/lib/compat.py for this stuff.
> > 
> > Then everyone needing json will do "from vdsm.compat import json"
> 
> Do you think is better to have an hard dependency on 'simplejson'
> or a soft one like I showed above hidden on compat.py?

It depends on the availability of simplejson. If it available
on all platforms, we can require it. 

> 
> I think we agree that 'explicit is better than implicit' here, so... (see
> below).

I prefer to see "json" in the code, even if we use simplejson library.
When we stop supporting Python 2.6 the only change we have to do is remove the
"soft" import mechanism.

Nir



More information about the Devel mailing list