[ovirt-devel] Changes related to gwt.userAgent property

[Vojtech Szocs]

Hi guys,

patch [1] just landed in master branch, it impacts the "gwt.userAgent"
Maven property used to control target browser(s) for GWT compilation.

[1] http://gerrit.ovirt.org/#/c/32164/

As you might know, Engine build process has several execution layers,
here they are in "bottom-up" order:

* Maven (Java) tool that works with pom.xml files
* make command that works with Makefile
* rpmbuild command that works with spec file (ovirt-engine.spec.in)

--

For Maven: "gwt.userAgent" default value is no longer "all browsers",
but "Firefox only". If you invoke Maven directly, please make sure to
check that you're passing correct "gwt.userAgent" value, for example:

  # omitting "gwt.userAgent" will default to "Firefox only"
  $ mvn [usual stuff] -Dgwt.userAgent=gecko1_8,safari

New Maven profile: all-user-agents -> for example:

  # build GWT apps for all supported browsers
  $ mvn [usual stuff] -Pall-user-agents

--

For make: existing behavior is preserved - build for "Firefox only"
by default. DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS default value is now
empty string, falling back to "gwt.userAgent" (Maven) default value.
Example how to customize target browser(s):

  $ make clean install-dev PREFIX=$HOME/ovirt-engine \
    DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=gecko1_8,safari"

New make option: BUILD_ALL_USER_AGENTS -> for example:

  # build GWT apps for all supported browsers
  $ make clean install-dev PREFIX=$HOME/ovirt-engine \
    BUILD_ALL_USER_AGENTS=1

Note: for non-devel builds, BUILD_DEV=0 so DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS
has no effect, thus falls back to "gwt.userAgent" (Maven) default value,
which is "Firefox only". As a result, for non-devel builds via make, use
BUILD_ALL_USER_AGENTS=1 to build for all supported browsers.

--

For rpmbuild: existing behavior is preserved - for default build
(i.e. not "quick" and "minimal" build), build for "all browsers"
by default.

Please see README.developer changes [2] for details.

[2] http://gerrit.ovirt.org/#/c/32164/4/README.developer

--

Regards,
Vojtech