[ovirt-devel] vdsm make rpm & make check on fe vs el

[Francesco Romani]

----- Original Message -----
> From: "Nir Soffer" <nsoffer at redhat.com>
> To: "Francesco Romani" <fromani at redhat.com>
> Cc: devel at ovirt.org, "Mooli Tayer" <mtayer at redhat.com>
> Sent: Monday, October 27, 2014 12:16:11 PM
> Subject: Re: [ovirt-devel] vdsm make rpm & make check on fe vs el


[...] 
> > > > I've also saw a different numbers of tests running for make rpm on el.
> > > 
> > > I have seen this on several 6.5 machines - make rpm on does *not* run
> > > the tests.
> > > 
> > > It would be nice if take a look at this.
> > 
> > It was made on purposes:
> > 
> > # Skips check since rhel default repos lack pep8 and pyflakes
> > %if ! 0%{?rhel}
> > %global with_check 1
> > %endif
> > 
> > http://gerrit.ovirt.org/#/c/29213/
> > 
> > I believe time has come for a more robust solution
> 
> As first aid, we should log something like "Skipping tests because ..."
> in this case.
> 
> I think we need to change that so we disable only pep8 in make rpm.
> 
> Nir

+1

we can afford to skip local checks (pep8/pyflakes), but the core test suite should run
anyway.

I'll post a patch today(ish) if noone is faster/disagrees with the above :)


-- 
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani