[ovirt-devel] Stable branch gerrit hook and Related-To: bug

Nir Soffer nsoffer at redhat.com
Wed Sep 17 09:21:03 UTC 2014


----- Original Message -----
> From: "Sven Kieske" <s.kieske at mittwald.de>
> To: devel at ovirt.org
> Sent: Wednesday, September 17, 2014 12:01:50 PM
> Subject: Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug
> 
> Why should an incomplete, thus non working feature get merged?

Adding a feature may require improving the design of the existing code. This 
may require multiple otherwise unrelated changes. The best way to  add these
changes is to make small clear and safe changes that leave the code in
functional state.

Reviewing and verifying small changes is much easier and safer and results
in less bugs and more stable code.

> Do you also merge incomplete bugfixes?

There is no such thing as "complete" in software or in life :-)

In general, bug fixes should be small and simple as possible, to limit the
risk to a stable code. Such fixes may be sometimes incomplete, since a complete
fix would required a risky redesign.

Nir



More information about the Devel mailing list