[ovirt-devel] Maintainer rights on vdsm - ovirt-3.5-gluster

[Balamurugan Arumugam]

----- Original Message -----
> From: "David Caro" <dcaro at redhat.com>
> To: "Sahina Bose" <sabose at redhat.com>
> Cc: "Dan Kenigsberg" <danken at redhat.com>, infra at ovirt.org, "Balamurugan Arumugam" <barumuga at redhat.com>,
> devel at ovirt.org
> Sent: Wednesday, April 29, 2015 1:38:03 PM
> Subject: Re: Maintainer rights on vdsm - ovirt-3.5-gluster
> 
> You want also push rights? It's not the same submit, push, create reference,
> verify, code review.
> 
> All those are different rights. I've added the submit, code-review and verify
> rights. Let me know if you want also the rest.
> 
> 
> Also note that pushing and submitting is not the same, pushing will skip
> gerrit
> and any gerrit checks, so it's usually something to avoid. While submitting
> is
> done through gerrit, what allows gerrit to check validity of the code to be
> merged (gerrit hooks, updating bugzillas, jenkins jobs, signed-by flabs).
> 

The idea behind push right is that we would do periodical rebase of ovirt-3.5-gluster branch with ovirt-3.5 branch.  Is this recommended way to do that?

Regards,
Bala




> On 04/29, Sahina Bose wrote:
> > 
> > On 04/20/2015 04:36 PM, Dan Kenigsberg wrote:
> > >On Mon, Apr 20, 2015 at 03:20:18PM +0530, Sahina Bose wrote:
> > >>Hi!
> > >>
> > >>On the vdsm branch "ovirt-3.5-gluster", could you provide merge rights to
> > >>Bala (barumuga at redhat.com) ?
> > >+1 from me.
> > >
> > >ovirt-3.5-gluster needs a rebase on top of the current ovirt-3.5
> > 
> > Hi!
> > 
> > Is there a push right to be enabled on this branch as well?
> > 
> > Currently, rebasing and pushing is failing with following:
> > 
> > remote: Branch refs/heads/ovirt-3.5-gluster:
> > remote: You are not allowed to perform this operation.
> > remote: To push into this reference you need 'Push' rights.
> > remote: User: bala
> > remote: Please read the documentation and contact an administrator
> > remote: if you feel the configuration is incorrect
> > remote: Processing changes: refs: 1, done
> > To ssh://bala@gerrit.ovirt.org:29418/vdsm.git
> >  ! [remote rejected] ovirt-3.5-gluster -> ovirt-3.5-gluster (prohibited by
> > Gerrit)
> > error: failed to push some refs to
> > 'ssh://bala@gerrit.ovirt.org:29418/vdsm.git'
> > 
> > _______________________________________________
> > Infra mailing list
> > Infra at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> 
> --
> David Caro
> 
> Red Hat S.L.
> Continuous Integration Engineer - EMEA ENG Virtualization R&D
> 
> Tel.: +420 532 294 605
> Email: dcaro at redhat.com
> Web: www.redhat.com
> RHT Global #: 82-62605
>