[ovirt-devel] Gerrit, only infra can remove reviewers

Tal Nisan tnisan at redhat.com
Mon Apr 13 09:05:14 UTC 2015



On 04/13/2015 10:41 AM, Moti Asayag wrote:
>
> ----- Original Message -----
>> From: "David Caro" <dcaroest at redhat.com>
>> To: devel at ovirt.org, infra at ovirt.org
>> Sent: Wednesday, April 8, 2015 7:24:42 PM
>> Subject: [ovirt-devel] Gerrit, only infra can remove reviewers
>>
>>
>> Effective now, only infra team members can remove reviewers from engine
>> master
>> and vdsm master.
> Can't you limit the list of removed reviewers only for the relevant reviewer
> list ? specifically for "gerrit-hooks" and "oVirt Jenkins CI Server" ?
I tend to agree with that, a false positive failed test can delay 
merging for days sometimes, can't you let specific people (maintainers 
for instance or a representative from each team) to remove reviewers?
>
> I'd like to have the ability to remove unintended reviewer from a patch (i.e.
> if was mistakenly added ).
>
> Also, can a user remove himself from the reviewer list of a given patch ?
>
>> That means that you'll have to poke one of us each time you
>> want to prevent jenkins (or anyone) from blocking any patches.
>>
>>
>> Enjoy!
>>
>>
>> --
>> David Caro
>>
>> Red Hat S.L.
>> Continuous Integration Engineer - EMEA ENG Virtualization R&D
>>
>> Tel.: +420 532 294 605
>> Email: dcaro at redhat.com
>> Web: www.redhat.com
>> RHT Global #: 82-62605
>>
>> _______________________________________________
>> Devel mailing list
>> Devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel




More information about the Devel mailing list