[ovirt-devel] No more "vds group" in master code , instead please use "cluster"

[Jakub Niedermertl]

Hi Eli,

are db migration scripts supposed to handle this change? My `engine-setup` failed with following message in log:

"""
2016-01-13 20:02:57 DEBUG otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database database.execute:172 Database: 'None', Statement: '
                SELECT compatibility_version FROM cluster;;
            ', args: {}
2016-01-13 20:02:57 DEBUG otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database database.execute:177 Creating own connection
2016-01-13 20:02:57 DEBUG otopi.context context._executeMethod:156 method exception
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 146, in _executeMethod
    method['method']()
  File "/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py", line 218, in _validation
    self._checkSupportedVersionsPresent()
  File "/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py", line 180, in _checkSupportedVersionsPresent
    transaction=False,
  File "/home/jakub/target/share/ovirt-**FILTERED**/setup/ovirt_**FILTERED**_setup/**FILTERED**_common/database.py", line 196, in execute
    args,
ProgrammingError: relation "cluster" does not exist
LINE 2:                 SELECT compatibility_version FROM cluster;;
                                                          ^

2016-01-13 20:02:57 ERROR otopi.context context._executeMethod:165 Failed to execute stage 'Setup validation': relation "cluster" does not exist
LINE 2:                 SELECT compatibility_version FROM cluster;;
                                                          ^
"""

Thank you for answer.

Best regards
Jakub


----- Original Message -----
> From: "Eli Mesika" <emesika at redhat.com>
> To: "devel" <devel at ovirt.org>
> Sent: Wednesday, January 13, 2016 12:00:50 AM
> Subject: [ovirt-devel] No more "vds group" in master code ,	instead please use "cluster"
> 
> Hi
> 
> I have merged today this patch[1] to master.
> 
> The code from historical reasons uses both "vds group" and "cluster" for a
> cluster entity.
> This makes the code not-clear, non-readable and hard for beginners (to find
> for example SPs that handle clusters , or all code related to a cluster
> operation)
> This also makes our logging and error messages using sometimes "vds group"
> and sometimes "cluster" to relate to the same entity.
> Worse than that, new code written sometimes introduce a mix of both terms.
> 
> Patch[1] renames "vds group" to cluster all over the code.
> This renaming covers all engine code including
>   Class names
>   Variables
>   Comments
>   Logging
>   Error messages
>   Database tables,views, columns and SPs including all kinds of keys and
>   constrains
> 
> Please do not use from now on the term "vds group" (all its variants
> (VdsGroup, vdsGroup, vds_group etc.)
> Instead , cluster and all its variants should be used
> 
> If you have some written code that is not merged yet, you will probably have
> a little work on rebase on top this patch, as far as I know those  should be
> trivial patches and if you have any question, please ask.
> 
> Possible affects on other products are minor and were communicated to the
> relevant product people.
> 
> [1] https://gerrit.ovirt.org/#/c/51109/
> 
> Thanks
> Eli Mesika
> 
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>