[ovirt-devel] [HEADS UP] ovift-engine: repository closure check on check-patch

[Sandro Bonazzola]

Il 24/Feb/2017 19:37, "Barak Korren" <bkorren at redhat.com> ha scritto:

Sorry, but I really don't think this is the right direction to go.

This exposes check-patch to outside repos and may result in
repo-stability-related failures after we've made great efforts to eliminate
those.

This kind of test should really be done at the OST stage IMO.


OST come into play too late, with patch already merged and dep tree broken.
It will avoid the rpm to be published but it will fail the subsequent ost
hiding other issues. Any suggestion on how to avoid it? Run OST in check
patch?



 I haven't merged the patches becauseI wanted feedback like this, thanks
Barack.






בתאריך 24 בפבר׳ 2017 18:01,‏ "Sandro Bonazzola" <sbonazzo at redhat.com> כתב:

>
>
> On Fri, Feb 24, 2017 at 4:59 PM, Sandro Bonazzola <sbonazzo at redhat.com>
> wrote:
>
>> Hi,
>> with the following commits:
>> - https://gerrit.ovirt.org/71553
>> - https://gerrit.ovirt.org/71623
>>
>> a minimal repository closure check is added to check-patches.sh.
>> Instead of performing a full blown repository closure, I limited the
>> check to the built rpms in oreder to reduce the risk of hitting repository
>> closure errors due to different projects.
>>
>> This should help dropping the long time failing repository closure jobs
>> which are struggling to keep the pace with the changes we introduce in
>> master.
>> It should also help avoiding to merge patches which will break the
>> repository and the plain rpm  install flow.
>>
>
> Forgot to mention I recomend to steal the check for your own project
> reducing repository closure issues as well :-)
>
>
>
>>
>> The second patch switch from ovirt-master-release to experimental repo.
>> Here I need infra input, not sure experimental is the desired repo,
>> deisgned to replace ovirt-master-snapshot.
>>
>> Thanks,
>> --
>> Sandro Bonazzola
>> Better technology. Faster innovation. Powered by community collaboration.
>> See how it works at redhat.com
>>
>
>
>
> --
> Sandro Bonazzola
> Better technology. Faster innovation. Powered by community collaboration.
> See how it works at redhat.com
>
> _______________________________________________
> Infra mailing list
> Infra at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20170225/2cc8e9da/attachment.html>