Change in ovirt-engine[master]: core: (Partially) Cleanup RunVmCommand

lhornyak at redhat.com lhornyak at redhat.com
Mon Jul 2 16:33:51 UTC 2012


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: (Partially) Cleanup RunVmCommand
......................................................................


core: (Partially) Cleanup RunVmCommand

(Partial) java cleanup to RunVmCommand:
1. Replaced deprecated StringHelper with common's StringUtils.
2. Replaced singleton access to external resources with protected access
   methods where possible.
3. Removed redundent null checks on canDoMessages.
4. Removed commented out block.
5. Made the log final.
6. Eclipse IDE formatting.

Change-Id: I1674446fbd448d800824cfc29c960a90329f31fa
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 54 insertions(+), 80 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5829
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1674446fbd448d800824cfc29c960a90329f31fa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>



More information about the Engine-commits mailing list