Change in ovirt-engine[master]: core: removal unneeded boolean and finally block from recove...

mlipchuk at redhat.com mlipchuk at redhat.com
Sun Feb 3 15:47:02 UTC 2013


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: removal unneeded boolean and finally block from recovery command.
......................................................................


core: removal unneeded boolean and finally block from recovery command.

When running reconstruct as internal command, there's no need to the
finally block as exceptions won't be thrown - therefore the finally
block and the used boolean can be removed safely.

Change-Id: I5c14601c1b9f5097c600c0139f785cbe43f4a588
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java
1 file changed, 37 insertions(+), 41 deletions(-)

Approvals:
  Maor Lipchuk: Looks good to me, approved
  Liron Aravot: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/11620
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5c14601c1b9f5097c600c0139f785cbe43f4a588
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>



More information about the Engine-commits mailing list