Change in ovirt-engine[master]: core: cleanup RemoveVmTemplateCommand#canDoAction

ofrenkel at redhat.com ofrenkel at redhat.com
Sun Jun 30 11:40:21 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: cleanup RemoveVmTemplateCommand#canDoAction
......................................................................


core: cleanup RemoveVmTemplateCommand#canDoAction

1. Replace consecutive lines of call to addCanDoActionMessage and then
'return false' with 'return failCanDoAction(..)'
2. Replace calls to DbFacade.getInstance() with call to getDbFacade()
3. Replace if-else statement with ternary-if

Change-Id: If669283fc057cff4eee46dfb15e004672d05fac1
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
1 file changed, 7 insertions(+), 14 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/15877
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If669283fc057cff4eee46dfb15e004672d05fac1
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list