Change in ovirt-engine[ovirt-engine-3.6.3]: Revert "core, webadmin: Not validating HostNetworkQos values"

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: Revert "core,webadmin: Not validating HostNetworkQos values"
......................................................................


Revert "core,webadmin: Not validating HostNetworkQos values"

This reverts commit 261b920b6a5e49d0ef0cc0d6b62284de2640529b.

This patch is probably mostly beneficial — it tries to workaround i
ssues with problematically testable *Parameters class, and allows
this *Parameters class to be validated using bean validation.
However doing so unravels another design issues, which cannot be
easily solved, and it's (at least for now) easier to rewrite those
validations programmatically and introduce duplicate code, than
trying to use bean validation.

Bug-Url: https://bugzilla.redhat.com/1271220
Signed-off-by: Martin Mucha <mmucha at redhat.com>
Change-Id: Ia6298732a81570795ab1be6f140acaf3d1cb5f88
(cherry picked from commit e9b952470ea31ddd1c07e9d862a49dac4821017d)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/businessentities/SeparateNewAndModifiedInstances.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 2 insertions(+), 71 deletions(-)

Approvals:
  Tal Nisan: Passed CI tests
  Martin Mucha: Verified
  Alona Kaplan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/52901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6298732a81570795ab1be6f140acaf3d1cb5f88
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>