Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix ClassCastException in SearchableListModel

tnisan at redhat.com tnisan at redhat.com
Tue Jan 26 16:11:42 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Fix ClassCastException in SearchableListModel
......................................................................


webadmin: Fix ClassCastException in SearchableListModel

When new items are selected and determineSelectedItems tries to restore the
selection, it blindly assumes that the list item is a subclass of IVdcQueryable
which is now always the case: e.g. in the ImportVmModel.

Change-Id: I679f132a2d23e285bd12380837d9eea58fb5f55d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1293269
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModelTest.java
2 files changed, 42 insertions(+), 3 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Tal Nisan: Passed CI tests
  Martin Betak: Verified



-- 
To view, visit https://gerrit.ovirt.org/52755
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I679f132a2d23e285bd12380837d9eea58fb5f55d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list