[Kimchi-devel] [PATCH] Issue#366: Guest Name Can't be Changed

[Christy Perez]

NACK.

Tested-By: Christy Perez <christy at linux.vnet.ibm.com>

This didn't change the name for my guest. There are no errors in the
logs. :/

I'm running Fedora 20 and using Firefox 28.

Regards,

- Christy


On Thu, 2014-04-10 at 16:27 +0800, Hongliang Wang wrote:
> When changing a guest name in Guest Tab, the change takes no effect because of
> a UI bug. Fix it in this patch.
> 
> Signed-off-by: Hongliang Wang <hlwang at linux.vnet.ibm.com>
> ---
>  ui/js/src/kimchi.guest_edit_main.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ui/js/src/kimchi.guest_edit_main.js b/ui/js/src/kimchi.guest_edit_main.js
> index 9375c51..b771263 100644
> --- a/ui/js/src/kimchi.guest_edit_main.js
> +++ b/ui/js/src/kimchi.guest_edit_main.js
> @@ -119,7 +119,7 @@ kimchi.guest_edit_main = function() {
>          var editableFields = [ 'name' ];
>          var data = {};
>          $.each(editableFields, function(i, field) {
> -            data[field] = $('#form-guest-edit [name="' + field + '"]').val();
> +            data[field] = $('input[name="' + field + '"]', guestEditForm).val();
>          });
>          kimchi.updateVM(kimchi.selectedGuest, data, function() {
>              kimchi.listVmsAuto();