[Kimchi-devel] [V6 5/5] manually manage the metadata element

[Sheldon]

On 04/24/2014 03:28 PM, Royce Lv wrote:
> Would you ignore or redirect the below error:
let me improve it.
>
> 127.0.0.1 - - [24/Apr/2014:15:26:47] "GET 
> /data/screenshots/233e8d1b-81a1-41af-97ec-2d3f2a886618-7bc8d298-a91c-4319-81a2-96f257a4d672.png 
> HTTP/1.0" 200 62801 "http://localhost:8000/" "Mozilla/5.0 (X11; 
> Ubuntu; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0"
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
> libvirt: QEMU Driver error : argument unsupported: QEMU driver does 
> not support <metadata> element
>
> I got this  all of my log.
> On 2014年04月24日 13:16, shaohef at linux.vnet.ibm.com wrote:
>> From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
>>
>> virDomain.metadata and virDomain.setMetadata does not work in all livirt
>> versions used in the supported distros.
>>
>> So if libvirt do not support these two API.
>>
>> let kimchi manually manage the metadata element
>>
>> Signed-off-by: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
>> Signed-off-by: Royce Lv <lvroyce at linux.vnet.ibm.com>
>> ---
>>   src/kimchi/model/utils.py | 38 +++++++++++++++++++++++++++++++++++---
>>   1 file changed, 35 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/kimchi/model/utils.py b/src/kimchi/model/utils.py
>> index be5e526..574ce9d 100644
>> --- a/src/kimchi/model/utils.py
>> +++ b/src/kimchi/model/utils.py
>> @@ -20,6 +20,7 @@
>>   from kimchi.exception import OperationFailed
>>   import libvirt
>>   from lxml import etree
>> +from lxml.builder import E
>>
>>
>>   KIMCHI_META_URL = "https://github.com/kimchi-project/kimchi/metadata/"
>> @@ -53,9 +54,30 @@ def set_vm_metadata_element(dom, meta_xml, 
>> mode="all"):
>>       # From libvirt doc, Passing None for @metadata says to remove 
>> that element
>>       # from the domain XML (passing the empty string leaves the 
>> element present)
>>       # Do not support remove the old metadata
>> -    dom.setMetadata(libvirt.VIR_DOMAIN_METADATA_ELEMENT, meta_xml,
>> -                    "kimchi", KIMCHI_META_URL + element.tag,
>> -                    flags=get_vm_config_flag(dom, mode))
>> +    try:
>> +        dom.setMetadata(libvirt.VIR_DOMAIN_METADATA_ELEMENT, meta_xml,
>> +                        "kimchi", KIMCHI_META_URL + element.tag,
>> +                        flags=get_vm_config_flag(dom, mode))
>> +    except libvirt.libvirtError as e:
>> +        # FIXME remove this code when all distro libvirt supports 
>> setMetadata
>> +        if e.get_error_code() == libvirt.VIR_ERR_ARGUMENT_UNSUPPORTED:
>> +            # some other tools will not let libvirt create a persistent
>> +            # configuration, raise exception.
>> +            if not dom.isPersistent():
>> +                msg = 'The VM has not a persistent configuration'
>> +                raise OperationFailed("KCHVM0029E",
>> +                                      {'name': dom.name(), "err": msg})
>> +            xml = dom.XMLDesc(libvirt.VIR_DOMAIN_XML_INACTIVE)
>> +            root = etree.fromstring(xml)
>> +            metadata = root.find("metadata")
>> +            if metadata is None:
>> +                metadata = E.metadata()
>> +                root.append(metadata)
>> +            old_elem = metadata.find(element.tag)
>> +            (metadata.replace(old_elem, element) if old_elem is not 
>> None
>> +             else metadata.append(element))
>> +
>> +            dom.connect().defineXML(etree.tostring(root))
>>
>>
>>   def get_vm_metadata_element(dom, element, mode="current"):
>> @@ -64,6 +86,16 @@ def get_vm_metadata_element(dom, element, 
>> mode="current"):
>>                               KIMCHI_META_URL + element,
>>                               flags=get_vm_config_flag(dom, mode))
>>       except libvirt.libvirtError as e:
>> +        # FIXME remove this code when all distro libvirt supports 
>> metadata
>> +        if e.get_error_code() == libvirt.VIR_ERR_ARGUMENT_UNSUPPORTED:
>> +            # some other tools will not let libvirt create a persistent
>> +            # configuration, just return empty
>> +            if not dom.isPersistent():
>> +                return ""
>> +            xml = dom.XMLDesc(libvirt.VIR_DOMAIN_XML_INACTIVE)
>> +            root = etree.fromstring(xml)
>> +            elements = root.xpath("metadata/%s" % element)
>> +            return etree.tostring(elements[0]) if elements else ""
>>           if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN_METADATA:
>>               return ""
>>           else:
>
>
>


-- 
Thanks and best regards!

Sheldon Feng(冯少合)<shaohef at linux.vnet.ibm.com>
IBM Linux Technology Center