[Kimchi-devel] [PATCH 1/2] Add persistent flag to VM info

[Christy Perez]

On 08/21/2014 12:15 PM, Crístian Viana wrote:
> On 20-08-2014 19:43, Christy Perez wrote:
>> Kimchi can manage guests not created by Kimchi. If a user creates a
>> non-persistent domain and uses the Power Off option, it will destroy
>> the user's domain. In order to warn users with non-persistent guests
>> on Power Off, this patch adds a 'persistent' field (like the one for
>> networks and storage pools) to a vm's JSON representation.
>>
>> Signed-off-by: Christy Perez <christy at linux.vnet.ibm.com>
> 
> This patch breaks the tests. Please run "sudo make check" and fix the
> errors.
> Other than fixing the test errors, please add a few specific tests for
> this property as well.
ACK. Thanks.
> 
>> -                'access': 'full'
>> +                'access': 'full',
>> +                'persistent': True if dom.isPersistent() else False
> "'persistent': dom.isPersistent()" should do the same thing in a clearer
> way.
I'm pretty sure I had that first, and just got back '1'. I'll
double-check, though.