[Kimchi-devel] [WIP][PATCH 0/4] Support upload volume to storagepool

[Royce Lv]

On 2014年08月22日 04:04, Aline Manera wrote:
>
> On 08/21/2014 11:42 AM, lvroyce0210 at gmail.com wrote:
>> From: Royce Lv <lvroyce at linux.vnet.ibm.com>
>>
>> Note:
>> The UI patch is just used for testing.
>>
>> Problem remains:
>> 1. POST return 404 because the UI patch does not include accept json
>> 2. task id does not returned in vol data and progress has not been added
>
> I can use the "message" in the task resource to return the volume name.
> That way we can display the UI with a loading icon (instead of the 
> progress bar) as is the option 2 on mock up
> ([Kimchi-devel] [RFC] UI Mockup - ISO Pool: Download from URL and Upload)
I want to discuss whether we would like to adopt Xiao Ding's resumable 
upload or upload at a time.
If we split file into pieces (just as Ding did in his patch), we will 
call POST /storagevolumes for multi times.
Advantage is we can resume upload after cancel it, because we tracked 
split block information.
But the API seems improper.

Meanwhile, we can adopt my way to transfer file all at a time.
We can't have the advantage of resume and pause, but the API definition 
seems keep align with the implementation.
>
>> 3. Haven't tested large file, so not sure whether we need to split 
>> large file into peices
>> and call POST multi-times.
>>
>> Royce Lv (3):
>> Storage volume upload: Dispatch volume create to right handler
>> Storage volume upload: Parse params for upload formdata
>> Storage volume upload: add model function of upload
>>
>> ssdxiao (1):
>> Support to upload ISO
>>
>> contrib/kimchi.spec.fedora.in | 3 +
>> contrib/kimchi.spec.suse.in | 3 +
>> po/en_US.po | 2 +
>> po/pt_BR.po | 3 +
>> po/zh_CN.po | 3 +
>> src/kimchi/API.json | 1 -
>> src/kimchi/control/storagepools.py | 4 +-
>> src/kimchi/control/utils.py | 2 +
>> src/kimchi/i18n.py | 1 +
>> src/kimchi/model/storagevolumes.py | 34 ++
>> src/nginx.conf.in | 1 +
>> ui/css/theme-default/upload.css | 43 ++
>> ui/js/resumable.js | 816 ++++++++++++++++++++++++++++++++++
>> ui/js/src/kimchi.template_add_main.js | 27 ++
>> ui/pages/kimchi-ui.html.tmpl | 1 +
>> ui/pages/template-add.html.tmpl | 13 +
>> 16 files changed, 954 insertions(+), 3 deletions(-)
>> create mode 100644 ui/css/theme-default/upload.css
>> create mode 100644 ui/js/resumable.js
>>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>