[Kimchi-devel] [PATCH 2/2] Remove empty directories on dpkg -e

Aline Manera alinefm at linux.vnet.ibm.com
Wed Dec 10 14:36:22 UTC 2014


On 12/10/2014 11:19 AM, Ramon Medeiros wrote:
> Signed-off-by: Ramon Medeiros <ramonn at linux.vnet.ibm.com>
> ---
>   contrib/make-deb.sh.in | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/contrib/make-deb.sh.in b/contrib/make-deb.sh.in
> index 5a6e56a..2de3540 100644
> --- a/contrib/make-deb.sh.in
> +++ b/contrib/make-deb.sh.in
> @@ -10,6 +10,8 @@ fi
>
>   TMPDIR=`mktemp -d`
>
> +mkdir -p $TMPDIR/var/lib/kimchi/{isos,vnc-tokens}

In the spec file you did:

+# create /var/lib/kimchi structure
+mkdir -p %{buildroot}/var/lib/kimchi/{debugreports,screenshots,vnc-tokens,isos}
+touch %{buildroot}/var/lib/kimchi/objectstore
+
+# create /var/log/kimchi structure
+mkdir -p %{buildroot}/var/log/kimchi/
+touch %{buildroot}/var/log/kimchi/kimchi-access.log
+touch %{buildroot}/var/log/kimchi/kimchi-error.log


Why that difference to deb?

Don't you need to update contrib/DEBIAN/postrm to really remove the 
directory on uninstall?

> +
>   make DESTDIR=$TMPDIR install-deb
>   dpkg-deb -b $TMPDIR kimchi-${VERSION}-${RELEASE}.noarch.deb
>   rm -rf $TMPDIR




More information about the Kimchi-devel mailing list