[Kimchi-devel] [PATCH 3/3] Add mailing list information.

[Leonardo Augusto Guimarães Garcia]

On 02/10/2014 01:09 PM, Aline Manera wrote:
> On 02/10/2014 01:02 PM, Leonardo Augusto Guimarães Garcia wrote:
>> Sorry, I may be new here and don't know exactly what you want. The
>> commit message has only one simple line and is in the subject of the
>> e-mail. This is a rather simple patch that only adds mailing list
>> information to the CONTRIBUTE.md file. Unless you want me to just repeat
>> the subject in the commit message body --- which I think is just a waste
>> of time and space --- I don't see exactly what you want me to add here.
>> Adding a commit message body just for the sake of having one does not
>> make sense --- unless I will write something meaningful.
>
> Yeap! I mean for the commit description. All commits must have one.
> Usually we don't repeat the commit message in it, otherwise we explain
> why the patch
> is needed in addition to what it is for (if the commit message does
> not contain many details)
Ok, I'll resend the patches...
>
>> Best regards,
>>
>> Leonardo Garcia
>>
>> On 02/10/2014 12:55 PM, Aline Manera wrote:
>>> Missing commit message
>>>
>>> On 02/10/2014 12:35 AM, Leonardo Garcia wrote:
>>>> From: Leonardo Garcia <lagarcia at br.ibm.com>
>>>>
>>>> Signed-off-by: Leonardo Garcia <lagarcia at br.ibm.com>
>>>> ---
>>>>    CONTRIBUTE.md | 6 +++---
>>>>    1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/CONTRIBUTE.md b/CONTRIBUTE.md
>>>> index 327c37e..f4dcaec 100644
>>>> --- a/CONTRIBUTE.md
>>>> +++ b/CONTRIBUTE.md
>>>> @@ -1,9 +1,9 @@
>>>>    How to Contribute
>>>>    =================
>>>>
>>>> -All development discussion happens on the mailing list.  All
>>>> development is
>>>> -done using the `git` SCM.  Patches should be sent using the `git
>>>> send-email`
>>>> -command.
>>>> +All development discussion happens on the mailing list.  All
>>>> development is done
>>>> +using the `git` SCM. Patches should be sent using the `git
>>>> send-email` command
>>>> +to the kimchi-devel at ovirt.org mailing list.
>>>>
>>>>    Good examples of how to send patches are included in
>>>>    [QEMU
>>>> SubmitAPatch](http://wiki.qemu.org/Contribute/SubmitAPatch) and
>