[Kimchi-devel] [PATCH V5 0/6] Storagepool SCSI/FC

[Aline Manera]

Also you need to rebase it and make the changes needed as the refactor 
exception patches were merged.
The backend translatable messages must be in i18n.py and you use the 
code while raising the exception.
Same for UI messages.

And let me make a suggestion: send a separated patch set for backend and UI
So one does not block other to me merged

On 02/12/2014 04:25 AM, Rodrigo Trujillo wrote:
> V5:
> - Add entries to API.md related to host pci devices API
> - Fix issues with wwpn and wwnn fields in lookup returns
> - Fix issues in mock model
> - Fix UI minor issues
> - Add UI strings to i18n
> - Refactored code accordig to code review suggestions
>
>
> V4:
> - Implements mockmodel and tests
> - Fix UI
> - Fix other minor issues
>
>
> V3:
> - Changed API to only receive the scsi host name when creating new pool
> - Changed API to require LUN when creating new VM on SCSI pool
> - Created feature test and removed libvirt test function
> - Rebased with new model structure
> - Added error function handlers to UIs
> - Fixed LUN selection window
>
>
> V2:
>
> - Implements Fibre Channel devices discover in the host
> - Allow vms_create receive a volume to create the disk (if pool is SCSI)
> - Create basic UI to select SCSI Host when creating SCSI FC pool
> - Draft of UI to select LUN to create new VM when template has a SCSI
>    pool configured. (Need help of UI guys here!)
>
> Rodrigo Trujillo (5):
>    Storagepool SCSI/FC: Implement node devices API backend
>    Storagepool SCSI/FC: Backend implementation
>    Storagepool SCSI/FC: Implement UI for FC scsi_host pool
>    Storagepool SCSI/FC: Modifies UI flow to select a LUN to new VM
>    Storagepool SCSI/FC: Modifies mockmodel and implements tests for FC
>      pool
>
> Rodrigo Trujillo (6):
>    Storagepool SCSI/FC: Implement node devices API backend
>    Storagepool SCSI/FC: API.md entries related to host pci devices
>    Storagepool SCSI/FC: Backend implementation
>    Storagepool SCSI/FC: Implement UI for FC scsi_host pool
>    Storagepool SCSI/FC: Modifies UI flow to select a LUN to new VM
>    Storagepool SCSI/FC: Modifies mockmodel and implements tests for FC
>      pool
>
>   docs/API.md                              | 34 ++++++++++++++-
>   src/kimchi/API.json                      | 14 +++++-
>   src/kimchi/control/host.py               | 16 +++++++
>   src/kimchi/featuretests.py               | 29 +++++++++++++
>   src/kimchi/mockmodel.py                  | 55 +++++++++++++++++++++---
>   src/kimchi/model/config.py               |  2 +
>   src/kimchi/model/host.py                 | 55 ++++++++++++++++++++++++
>   src/kimchi/model/libvirtstoragepool.py   | 48 ++++++++++++++++++++-
>   src/kimchi/model/storagepools.py         | 30 +++++++++++--
>   src/kimchi/model/templates.py            |  5 +++
>   src/kimchi/model/vms.py                  | 27 ++++++++++--
>   src/kimchi/vmtemplate.py                 | 31 +++++++++++++-
>   tests/test_rest.py                       | 62 +++++++++++++++++++++++++++
>   tests/test_storagepool.py                | 21 +++++++++
>   ui/js/src/kimchi.api.js                  | 24 +++++++++++
>   ui/js/src/kimchi.guest_add_main.js       | 73 ++++++++++++++++++++++++++++++--
>   ui/js/src/kimchi.storagepool_add_main.js | 46 +++++++++++++++++++-
>   ui/pages/i18n.html.tmpl                  |  8 ++++
>   ui/pages/storagepool-add.html.tmpl       | 12 ++++++
>   19 files changed, 569 insertions(+), 23 deletions(-)
>