[Kimchi-devel] [PATCH] issue #316: Only verify if path starts with '/'

Rodrigo Trujillo rodrigo.trujillo at linux.vnet.ibm.com
Mon Feb 24 17:35:28 UTC 2014


Reviewed-by: Rodrigo Trujillo <rodrigo.trujillo at linux.vnet.ibm.com>

On 02/24/2014 01:21 PM, Aline Manera wrote:
> From: Aline Manera <alinefm at br.ibm.com>
>
> Any character is allowed in a Linux path.
> So while creating a DIR storage pool we just need to make sure the path
> starts with '/' and backend will properly check if it exists on the
> system.
>
> Signed-off-by: Aline Manera <alinefm at br.ibm.com>
> ---
>   ui/js/src/kimchi.storagepool_add_main.js |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js
> index 574cf5a..1e3e4b4 100644
> --- a/ui/js/src/kimchi.storagepool_add_main.js
> +++ b/ui/js/src/kimchi.storagepool_add_main.js
> @@ -167,7 +167,7 @@ kimchi.validateDirForm = function () {
>           kimchi.message.error.code('KCHPOOL6002E');
>           return false;
>       }
> -    if (!/((\/([0-9a-zA-Z-_\.]+)))$/.test(path)) {
> +    if (!/(^\/.*)$/.test(path)) {
>           kimchi.message.error.code('KCHAPI6003E');
>           return false;
>       }




More information about the Kimchi-devel mailing list