[Kimchi-devel] [PATCH 0/3] template integrity verification: verify storagepool

[Sheldon]

On 02/26/2014 04:22 PM, Sheldon wrote:
> On 02/26/2014 03:53 PM, Shu Ming wrote:
>> 2014/2/26 11:08, shaohef at linux.vnet.ibm.com:
>>> From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
>>>
>>> Sometimes, user create a template, storagepool will change later.
>>> So users can not create a vm from this template successfully.
>>> It is necessary to check storagepool of a template.
>>>
>>> By the way storagepool, this verification does not depend on volume 
>>> ref_cnt
>>> Storagepool delete depends on volume ref_cnt
>>> I make a mistake.
>>> So sorry.
>> It seems the two lines above confused me.
> This is cover letter message.
>
> For template integrity, we need to verify storagepool exist, we do not 
> need to check
> the all volume ref_cnt. (royce's patch)
>
>
> But for delete storagepool, we need to check the all volume ref_cnt is 
> zero.
> This will be another patch for storagepool delete verification later.
>
I thought  template integrity and delete storagepool are both depends on 
royce's patch（volume ref_cnt) at first.
And my thought is wrong.
>>
>>>
>>> ShaoHe Feng (3):
>>> template integrity verification: verify storagepool, update API.md
>>> template integrity verification: verify storagepool in backend
>>> template integrity verification: update test case to verify
>>> storagepool
>>>
>>> docs/API.md | 1 +
>>> src/kimchi/mockmodel.py | 3 +++
>>> src/kimchi/model/templates.py | 5 +++++
>>> src/kimchi/vmtemplate.py | 10 ++++++++++
>>> tests/test_model.py | 9 +++++++++
>>> tests/test_rest.py | 13 +++++++++++++
>>> 6 files changed, 41 insertions(+)
>>>
>>
>> _______________________________________________
>> Kimchi-devel mailing list
>> Kimchi-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>
>>
>>
>
>


-- 
Thanks and best regards!

Sheldon Feng(冯少合)<shaohef at linux.vnet.ibm.com>
IBM Linux Technology Center