[Kimchi-devel] [PATCH v2 0/2] Github bug #307: Add storage pool list

[Crístian Viana]

Reviewed-by: Crístian Viana <vianac at linux.vnet.ibm.com>

Am 28-02-2014 16:50, schrieb Daniel Barboza:
> From: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>
>
> Changelog:
> v2:
> - Fixing message ID
>
> These patches fixes the bug where the list of storage pool
> types can take a long time to appear. The solution used here
> is to detach the view of such list with the return of the
> JSON that loads the partition data.
>
> To test this patch I recomend doing the following change in
> src/kimchi/model/hosts.py:
>
> + import time
>
> class PartitionsModel(object):
>      def __init__(self, **kargs):
>          pass
>
>      def get_list(self):
> +        time.sleep(10)
>          result = disks.get_partitions_names()
>          return result
>
>
> The sleep(10) call will ensure that get_list (which returns the
> partition data) will take at least 10 seconds to execute. It is
> enough time to select the LOGICAL type and see how the UI is
> working before and after the JSON call.
>
>
> Daniel Henrique Barboza (2):
>    Github bug #307: add storage pool type list - JS changes
>    Github bug #307: storage pool type list - html and string changes
>
>   po/en_US.po                              |  21 +++-
>   po/kimchi.pot                            |  20 +++-
>   po/pt_BR.po                              |  21 +++-
>   po/zh_CN.po                              |  21 +++-
>   ui/js/src/kimchi.storagepool_add_main.js | 177 ++++++++++++++++---------------
>   ui/pages/i18n.html.tmpl                  |   5 +-
>   ui/pages/storagepool-add.html.tmpl       |   7 +-
>   7 files changed, 177 insertions(+), 95 deletions(-)
>