[Kimchi-devel] [PATCH 1/6] isoinfo: Add default value for ignore_list paramter

Sheldon shaohef at linux.vnet.ibm.com
Mon Jan 6 15:22:24 UTC 2014


Reviewed-by: ShaoHe Feng <shaohef at linux.vnet.ibm.com>

On 01/06/2014 11:05 PM, Aline Manera wrote:
> From: Aline Manera <alinefm at br.ibm.com>
>
> ignore_list parameter was added to avoid displaying duplicated results during
> deep scan.
> So isoinfo main program must be updated accordingly or it will raise the
> following error:
>
> $ python kimchi/isoinfo.py http://localhost/Fedora-Live-Desktop-x86_64-19-1.iso
> Traceback (most recent call last):
>    File "kimchi/isoinfo.py", line 343, in <module>
>      probe_iso(None, dict(path=sys.argv[1], updater=updater))
>    File "kimchi/isoinfo.py", line 283, in probe_iso
>      ignore_list = params['ignore_list']
> KeyError: 'ignore_list'
>
> Signed-off-by: Aline Manera <alinefm at br.ibm.com>
> ---
>   src/kimchi/isoinfo.py |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/kimchi/isoinfo.py b/src/kimchi/isoinfo.py
> index f76fd90..3d57533 100644
> --- a/src/kimchi/isoinfo.py
> +++ b/src/kimchi/isoinfo.py
> @@ -280,7 +280,7 @@ def probe_iso(status_helper, params):
>       loc = params['path'].encode("utf-8")
>       updater = params['updater']
>       ignore = False
> -    ignore_list = params['ignore_list']
> +    ignore_list = params.get('ignore_list', [])
>
>       def update_result(iso, ret):
>           if ret != ('unknown', 'unknown'):


-- 
Thanks and best regards!

Sheldon Feng(冯少合)<shaohef at linux.vnet.ibm.com>
IBM Linux Technology Center




More information about the Kimchi-devel mailing list