[Kimchi-devel] [PATCH V4 0/3] network improvment: add vms field

[Aline Manera]

On 01/06/2014 04:27 PM, Aline Manera wrote:
> On 01/06/2014 06:49 AM, shaohef at linux.vnet.ibm.com wrote:
>> From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
>>
>> V3 -> V4
>> the subject of patch V3 3/3 is wrong.
>
> Ops... the commit message still has a typo
>
> s/improvment/improvement
>

Otherwise, the patch set is ready to be merged in my opinion.

>> fix it.
>>
>> V2 -> V3
>> update mockmodel and test case
>>
>> V1 -> V2
>> set the flags argument of listAllDomains as 0 explicitly.
>> For in some distros:
>> $ pydoc libvirt.virConnect.listAllDomains
>> libvirt.virConnect.listAllDomains = listAllDomains(self, flags) \
>> unbound libvirt.virConnect method
>>
>> And in other distros:
>> $ pydoc libvirt.virConnect.listAllDomains
>> libvirt.virConnect.listAllDomains = listAllDomains(self, flags=0) \
>> unbound libvirt.virConnect method
>>
>> ShaoHe Feng (3):
>>    network improvment: add vms field
>>    network improvment: update mockmodel to support vms field
>>    network improvment: update test case to support vms field
>>
>>   docs/API.md                    |  1 +
>>   src/kimchi/control/networks.py |  1 +
>>   src/kimchi/mockmodel.py        |  9 +++++++++
>>   src/kimchi/model.py            | 15 +++++++++++++++
>>   tests/test_model.py            |  1 +
>>   tests/test_rest.py             |  3 +++
>>   6 files changed, 30 insertions(+)
>>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>