[Kimchi-devel] [PATCH V5 0/3] network improvment: add vms field

[Sheldon]

discuss with most of us today:
this patch set is what we need.

most of us prefer:
get /networks/
[
{''net1": {bridge: brg1, vms: [vm1, vm2]},
{''net2": {bridge: brg2, vms: [vm3, vm4, vm5]}
]

not
get /networks/
[
{''net1": {bridge: brg1, vms: 2},
{''net2": {bridge: brg2, vms: 3}
]



On 01/07/2014 02:50 PM, shaohef at linux.vnet.ibm.com wrote:
> From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
>
> V4 -> V5
> fix typo in subject.
>
> V3 -> V4
> the subject of patch V3 3/3 is wrong.
> fix it.
>
> V2 -> V3
> update mockmodel and test case
>
> V1 -> V2
> set the flags argument of listAllDomains as 0 explicitly.
> For in some distros:
> $ pydoc libvirt.virConnect.listAllDomains
> libvirt.virConnect.listAllDomains = listAllDomains(self, flags) \
> unbound libvirt.virConnect method
>
> And in other distros:
> $ pydoc libvirt.virConnect.listAllDomains
> libvirt.virConnect.listAllDomains = listAllDomains(self, flags=0) \
> unbound libvirt.virConnect method
>
> ShaoHe Feng (3):
>    network improvement: add vms field
>    network improvement: update mockmodel to support vms field
>    network improvement: update test case to support vms field
>
>   docs/API.md                    |  1 +
>   src/kimchi/control/networks.py |  1 +
>   src/kimchi/mockmodel.py        |  9 +++++++++
>   src/kimchi/model.py            | 15 +++++++++++++++
>   tests/test_model.py            |  1 +
>   tests/test_rest.py             |  3 +++
>   6 files changed, 30 insertions(+)
>


-- 
Thanks and best regards!

Sheldon Feng(冯少合)<shaohef at linux.vnet.ibm.com>
IBM Linux Technology Center

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20140108/cf415a27/attachment.html>