[Kimchi-devel] [PATCH] Fix qemu-io option in featuretests

Mark Wu wudxw at linux.vnet.ibm.com
Fri Jan 10 05:46:57 UTC 2014


qemu-io refuses to open curl block device if no read-only option
given in qemu1.6, which will cause the feature tests always fail
even it supports. For details, please refer to:
https://github.com/qemu/qemu/commit/a7cea2

Signed-off-by: Mark Wu <wudxw at linux.vnet.ibm.com>
---
 src/kimchi/featuretests.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/kimchi/featuretests.py b/src/kimchi/featuretests.py
index d9409ae..a5755a2 100644
--- a/src/kimchi/featuretests.py
+++ b/src/kimchi/featuretests.py
@@ -71,7 +71,7 @@ class FeatureTests(object):
 
     @staticmethod
     def qemu_supports_iso_stream():
-        cmd = "qemu-io http://127.0.0.1:%d/images/icon-fedora.png \
+        cmd = "qemu-io -r http://127.0.0.1:%d/images/icon-fedora.png \
               -c 'read -v 0 512'" % cherrypy.server.socket_port
         proc = subprocess.Popen(cmd, stdout=subprocess.PIPE,
                                 stderr=subprocess.PIPE, shell=True)
@@ -80,7 +80,7 @@ class FeatureTests(object):
 
     @staticmethod
     def qemu_iso_stream_dns():
-        cmd = ["qemu-io", "http://localhost:%d/images/icon-fedora.png" %
+        cmd = ["qemu-io", "-r", "http://localhost:%d/images/icon-fedora.png" %
                cherrypy.server.socket_port, "-c", "'read -v 0 512'"]
         proc = subprocess.Popen(cmd, stdout=subprocess.PIPE,
                                 stderr=subprocess.PIPE)
-- 
1.8.4.2




More information about the Kimchi-devel mailing list