[Kimchi-devel] About the pre-integration test

[Aline Manera]

On 01/15/2014 06:05 AM, Shu Ming wrote:
> Hi,
>
>
> After running the full unit-test cases by "sudo ./run_test.sh", I found
> the test cases were broken in all platforms including Fedora 20, Fedora
> 18, Ubuntu 12.04.

I need to disagree. I am running kimchi on Ubuntu 13.10 and all tests 
passed.

> I am not sure which patch broke it, but I think we
> should make sure all the existing unit-test cases passed before
> integration.
>
> To the maintainer, please enforce it when merging the patches.

Thanks for the tip but I've already done that.
But of course, I tested the patches in my system (Ubuntu 13.10) in which 
all the tests passed.

>   To the
> patch's submitter, please do a full unit test before submitting your
> patches into the mailing lists. It is very common for a new patch to
> trigger other test case's failure which seems non-related. Please make
> your code clean by the unit test cases. The unit test cases may take one
> minute, but it will save other's time in hours.
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>